unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: Glenn Morris <rgm@gnu.org>, 43359@debbugs.gnu.org
Subject: bug#43359: package-tests leave temporary files behind
Date: Fri, 23 Oct 2020 12:51:41 +0200	[thread overview]
Message-ID: <871rhpi5aa.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmn42rKwLJw8Mb8JTaah_cpiDJmx8P6EwkKv-2MRpTEY8A@mail.gmail.com> (Stefan Kangas's message of "Thu, 22 Oct 2020 17:27:31 -0700")

Stefan Kangas <stefan@marxist.se> writes:

> The alternative, I guess is something like:

[...]

> +       (when ,upload-base
> +         (dolist (f '("archive-contents"
> +                      "simple-single-1.3.el"
> +                      "simple-single-1.4.el"
> +                      "simple-single-readme.txt"))
> +           (ignore-errors
> +             (delete-file
> +              (expand-file-name f package-test-archive-upload-base))))
> +         (delete-directory package-test-archive-upload-base))
>         (when (file-directory-p package-test-user-dir)
>           (delete-directory package-test-user-dir t))
>
> But I don't think it's worth it...

If that cleans out all the left-behind files/directories, I'd prefer
that instead of the recursive deletion.  So go ahead and push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-10-23 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 18:02 bug#43359: package-tests leave temporary files behind Glenn Morris
2020-09-13 14:32 ` Lars Ingebrigtsen
2020-10-23  0:27   ` Stefan Kangas
2020-10-23 10:51     ` Lars Ingebrigtsen [this message]
2020-10-23 11:04       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rhpi5aa.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=43359@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).