From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42966: 28.0.50; vc-dir: wrong backend Date: Mon, 26 Oct 2020 22:58:46 +0100 Message-ID: <871rhktzs9.fsf@gnus.org> References: <54k0vq420i.fsf@fencepost.gnu.org> <87pn5h1j4b.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11045"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: sds@gnu.org, 42966@debbugs.gnu.org, Dmitry Gutov To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 26 23:08:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXAfC-0002m3-Ks for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 23:08:26 +0100 Original-Received: from localhost ([::1]:46598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXAfB-00027m-Iu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 18:08:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXAW6-0001n2-D7 for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 17:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXAW5-0004SB-Tw for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 17:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXAW5-0005Yy-SQ for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 17:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 21:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160374954021376 (code B ref 42966); Mon, 26 Oct 2020 21:59:01 +0000 Original-Received: (at 42966) by debbugs.gnu.org; 26 Oct 2020 21:59:00 +0000 Original-Received: from localhost ([127.0.0.1]:41801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAW3-0005Yi-NH for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:58:59 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAW2-0005YS-82 for 42966@debbugs.gnu.org; Mon, 26 Oct 2020 17:58:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ztQHOTAHWaUtyRrKiEg1sHcJJEKKaQIEYyEHZjLnn9Y=; b=O4b68Bz4p/d0RaireiIcuVQ2pg YkxJIAZPpRYUTT9eKE1/DR6Y3vl4ArJP0GVfLaGUWfmjiZv32RM7E9kBgLRi30Hpd1vIkpZfPZnyR Q54U7s5/3EoPUZwxjkcz256QrK/PMFkJt+xwAwtKYCBOav9pg/szD/U4yqgD6dvOEHwk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXAVs-0006Rj-8D; Mon, 26 Oct 2020 22:58:51 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEU6KhyiYCTRlCl9 ik3///+AXhrdAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKGRIVJDK0hlsAAAGBSURBVDjLdVMBkoMw CAT9AOAHGvoBNf//2y3ERHPe0ZnWZlkgu0gUoapW8KVCV2j7Ye1xnXPPwIm5lzdgyg7ARqkeTBwM khdCyVB6UzQBmRCJ6RrjnqsBKnGekN8UFuYYNkLNbeQHPS6dFzEftaIu44Mz9PABsEW2JODBkgdB WbTN6zfDUlQAV3sv0gGLe7EiO0kd0EP9aJK3gbsnuulZ0SVNSWA0t63iIiJL3GICyhFsYYjLhZ/j xh/+sAfxAVi6gPwSBYeEaPgFH4liYzkaYGchWqG9TzZxM4cLlE9rHm7kohUICMmWe+U2S68hDirq o3kJFSAW2Wefmi8hIm8LxfYCvxG0FP0KmUyLKIq/ekBs0+c5APSwuqPSvIXNhcoHFHl2IHdLb/T0 J2MlbEF7PKdS+/34q/etmfk/wFjntV5G9a3wzwT49UrwVy+gXgzRNv1Wx6StdkmC0JYTrmPOVon7 a7nWThQNw1le72tulTC9As0z9wX1CsPUdV//TOjxA3KlKy2pWrTWAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIwLTEwLTI1VDE4OjIxOjM2KzAwOjAwWmPCWAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0x MC0yNVQxODoyMTozNiswMDowMCs+euQAAAAASUVORK5CYII= X-Now-Playing: Prince's _Sign 'O' the Times (1)_: "Slow Love" In-Reply-To: (Glenn Morris's message of "Mon, 26 Oct 2020 17:54:19 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191678 Archived-At: Glenn Morris writes: > Indeed, it just seems like the Right Thing to Do, not a hack. > Not having been paying attention, I was surprised to see the adopted solution > goes for "loop over every VC backend, and every directory up the tree, > then filter the results", rather than "walk up the directory tree, > stopping when a backend claims responsibility". That would be the natural thing to do, but would be an incompatible interface change. (Only important for out-of-tree backends, though.) And it would require tweaking a handful of the in-tree backends; see the overview I posted the other week, but it didn't look complicated. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no