From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Newsgroups: gmane.emacs.bugs Subject: bug#37127: [PATCH] A final tweak: Skip the test for older Emacsen Date: Mon, 02 Nov 2020 23:52:56 +0100 Message-ID: <871rhbl6bb.fsf@hajtower> References: <87ftlu67cy.fsf@vinc17.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19351"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) To: 37127@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 02 23:54:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZiiT-0004un-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 23:54:21 +0100 Original-Received: from localhost ([::1]:50694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZiiS-0002Af-3b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 17:54:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZiiA-0002AS-QN for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 17:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZiiA-00067u-H1 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 17:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZiiA-0007sm-GA for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 17:54:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87ftlu67cy.fsf@vinc17.net> Resent-From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2020 22:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed Original-Received: via spool by 37127-submit@debbugs.gnu.org id=B37127.160435758730230 (code B ref 37127); Mon, 02 Nov 2020 22:54:02 +0000 Original-Received: (at 37127) by debbugs.gnu.org; 2 Nov 2020 22:53:07 +0000 Original-Received: from localhost ([127.0.0.1]:42888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZihG-0007rW-U6 for submit@debbugs.gnu.org; Mon, 02 Nov 2020 17:53:07 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:55302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZihE-0007r2-Rm for 37127@debbugs.gnu.org; Mon, 02 Nov 2020 17:53:05 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E5E40160060 for <37127@debbugs.gnu.org>; Mon, 2 Nov 2020 23:52:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1604357577; bh=sMl+rYZkUZZqXOI7sCXWJDnpQoSHugyejfCvqIFcTMY=; h=From:To:Subject:Date:From; b=CRnNl+Xe8F0+UzSPf8Won/u+4KXyQHznKF5f9C23VZrzmAXzcGMKw4rEpDf9pI0NK vv6SuLmv80EyOumsqVZnlHvONztCtFV1oidu/n8bUyENjPVkJAqFIM1wVN5DhXVpEb aqzBwx04kxIHxk6bFSU8L+LLHBrJJxGoQRD04vPXuwOhe/Tu/PP/fn79scfZ56vFHt LSlELveh/hw55D/8UEXJNBj8X9jgB3hrKKfENmo8CoJFzJ6GbNPIsEqAvXXPSUXURh le+4KJSrgCVnYLL9q8c5wdVuA4iEM2bYdA9bvXgAt4nAj4qyKB7LWQGVOp3k54JMqw e+WrQdx1aD1Hg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CQ7VK2cB7z9rxD for <37127@debbugs.gnu.org>; Mon, 2 Nov 2020 23:52:57 +0100 (CET) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192579 Archived-At: --=-=-= Content-Type: text/plain The current fix for this bug is in simple.el. This comes with the side effect that it will not be available in older Emacs versions when CPerl mode makes its way to GNU ELPA. The bug is completely harmless, I guess that porting the fix to older versions isn't worth the effort. I suggest to just skip the test when run under Emacs < 28, though this isn't strictly mandatory in the Emacs repository. -- Cheers, haj --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-cperl-mode-Skip-a-test-for-older-Emacsen-preparing-f.patch Content-Description: Skip a test for older Emacsen >From 365163de04a42ea9a24a56a8d68781988def8f42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20J=C3=B6rg?= Date: Mon, 2 Nov 2020 23:44:58 +0100 Subject: [PATCH] cperl-mode: Skip a test for older Emacsen (preparing for ELPA) * test/lisp/progmodes/cperl-mode-tests.el (cperl-bug37127): Skip this test for older Emacsen. The bug has been fixed in Emacs, but outside of CPerl mode, and therefore will not be available for older versions via ELPA. --- test/lisp/progmodes/cperl-mode-tests.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmodes/cperl-mode-tests.el index 9a7b5e4d6d..dcde3b68a0 100644 --- a/test/lisp/progmodes/cperl-mode-tests.el +++ b/test/lisp/progmodes/cperl-mode-tests.el @@ -224,6 +224,10 @@ cperl-bug37127 "Verify that closing a paren in a regex goes without a message. Also check that the message is issued if the regex terminator is missing." + ;; The actual fix for this bug is in simple.el, which is not + ;; backported to older versions of Emacs. Therefore we skip this + ;; test if we're running Emacs 27 or older. + (skip-unless (< 27 emacs-major-version)) ;; Part one: Regex is ok, no messages (ert-with-message-capture collected-messages (with-temp-buffer -- 2.20.1 --=-=-=--