From: haj@posteo.de (Harald Jörg)
To: 37127@debbugs.gnu.org
Subject: bug#37127: [PATCH] A final tweak: Skip the test for older Emacsen
Date: Mon, 02 Nov 2020 23:52:56 +0100 [thread overview]
Message-ID: <871rhbl6bb.fsf@hajtower> (raw)
In-Reply-To: <87ftlu67cy.fsf@vinc17.net>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
The current fix for this bug is in simple.el. This comes with the side
effect that it will not be available in older Emacs versions when CPerl
mode makes its way to GNU ELPA.
The bug is completely harmless, I guess that porting the fix to older
versions isn't worth the effort. I suggest to just skip the test when
run under Emacs < 28, though this isn't strictly mandatory in the Emacs
repository.
--
Cheers,
haj
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Skip a test for older Emacsen --]
[-- Type: text/x-diff, Size: 1302 bytes --]
From 365163de04a42ea9a24a56a8d68781988def8f42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Harald=20J=C3=B6rg?= <haj@posteo.de>
Date: Mon, 2 Nov 2020 23:44:58 +0100
Subject: [PATCH] cperl-mode: Skip a test for older Emacsen (preparing for
ELPA)
* test/lisp/progmodes/cperl-mode-tests.el (cperl-bug37127):
Skip this test for older Emacsen. The bug has been fixed
in Emacs, but outside of CPerl mode, and therefore will not
be available for older versions via ELPA.
---
test/lisp/progmodes/cperl-mode-tests.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmodes/cperl-mode-tests.el
index 9a7b5e4d6d..dcde3b68a0 100644
--- a/test/lisp/progmodes/cperl-mode-tests.el
+++ b/test/lisp/progmodes/cperl-mode-tests.el
@@ -224,6 +224,10 @@ cperl-bug37127
"Verify that closing a paren in a regex goes without a message.
Also check that the message is issued if the regex terminator is
missing."
+ ;; The actual fix for this bug is in simple.el, which is not
+ ;; backported to older versions of Emacs. Therefore we skip this
+ ;; test if we're running Emacs 27 or older.
+ (skip-unless (< 27 emacs-major-version))
;; Part one: Regex is ok, no messages
(ert-with-message-capture collected-messages
(with-temp-buffer
--
2.20.1
next prev parent reply other threads:[~2020-11-02 22:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 12:17 bug#37127: 27.0.50; in cperl mode, scan-error Unbalanced parentheses Vincent Lefevre
2019-10-03 23:02 ` Stefan Kangas
2020-10-29 21:11 ` bug#37127: [PATCH] cperl-mode: Suppress a misleading message Harald Jörg
2020-10-30 12:24 ` Lars Ingebrigtsen
2020-10-30 14:30 ` Stefan Monnier
2020-10-30 20:19 ` Harald Jörg
2020-10-30 22:12 ` Stefan Monnier
2020-10-31 1:09 ` Harald Jörg
2020-11-02 22:52 ` Harald Jörg [this message]
2020-11-02 23:13 ` bug#37127: [PATCH] A final tweak: Skip the test for older Emacsen Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rhbl6bb.fsf@hajtower \
--to=haj@posteo.de \
--cc=37127@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).