From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format Date: Wed, 04 Nov 2020 23:53:56 +0100 Message-ID: <871rh8vim3.fsf@gmx.net> References: <87imb7e242.fsf@gmx.net> <83zh4ipbli.fsf@gnu.org> <877drm13j3.fsf@gmx.net> <831rhuoy36.fsf@gnu.org> <87y2k2yqqb.fsf@gmx.net> <87h7qori97.fsf@gmx.net> <874kmcfy2h.fsf@rub.de> <875z6rmlrj.fsf@rub.de> <87r1pcu155.fsf@rub.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7864"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44068@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 04 23:55:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaRgU-0001wa-EK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Nov 2020 23:55:18 +0100 Original-Received: from localhost ([::1]:38344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaRgT-0006Zx-GD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Nov 2020 17:55:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaRgF-0006ZV-2O for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 17:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaRgE-0008CS-LW for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 17:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kaRgE-0001nU-GU for bug-gnu-emacs@gnu.org; Wed, 04 Nov 2020 17:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Nov 2020 22:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44068 X-GNU-PR-Package: emacs Original-Received: via spool by 44068-submit@debbugs.gnu.org id=B44068.16045304526846 (code B ref 44068); Wed, 04 Nov 2020 22:55:02 +0000 Original-Received: (at 44068) by debbugs.gnu.org; 4 Nov 2020 22:54:12 +0000 Original-Received: from localhost ([127.0.0.1]:50937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaRfQ-0001mM-Em for submit@debbugs.gnu.org; Wed, 04 Nov 2020 17:54:12 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:43753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaRfP-0001mA-1l for 44068@debbugs.gnu.org; Wed, 04 Nov 2020 17:54:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604530444; bh=+YyC70a87Q7sv9RIzEwZzIkiSNLoClHm+jIyDkk4eT4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=DXgkFY639xDMDaAEqDdXz7iHX7RR6bRAXetuUtlTljZVOSESE5maQWDpKI1DbZnpv OL/JrQT0+5kYehKn5+41gYd8LtMP+Yzlg58IMFcOfJnFJhI1Fo1BUrKWo8osCcYLRZ OHi12ZB19cluTk6Eh70wvcb9CVMpZs3i6eKcMKDw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([178.1.124.54]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmlTC-1jt6lu002g-00jp3X; Wed, 04 Nov 2020 23:54:04 +0100 In-Reply-To: (Stefan Kangas's message of "Wed, 4 Nov 2020 04:02:04 -0800") X-Provags-ID: V03:K1:wUzCUujWjgr2hZzOH7JQRq6W+ujJJOqUKBc81op4dMOOc4Blh11 jVeYYasbdoR+U5eVkAkwpHdllQYIVfNPv0nidxVzuSmQAxPDvDtnfuwyqYKsDf449e3ThNQ gPTDpHy5vd9F0v/mVDBFPDWE3HZIx3KacLu2xTmeKvnH5kmR80jSDm6Yti2Re9gR0fdV4SN Z/J9C8NL1fUMnIsB+3Itg== X-UI-Out-Filterresults: notjunk:1;V03:K0:1njK0l6of08=:kPZfOytXX6AeB7Gp5P4uLo EbDjb6mjzbuvNwt5uQqSPVvibmVtCW9EMFOWXY8fwwKIS/DmGfGAfFAH2FcSclfiezuF9SD4e 2z43rUAMfaIN5xaV83DQtsmHTnypW3ObLB7VL0LPBNzoNWLGfyu1yb52VaQlxPK21mQUrjP3d VS/+ZoaiupugECnSIOTidPoWlsDa9NzuL0qeKMEOJ/VpBkje7E1uG/kYBK6OdEThjI8E9wNXJ zMXH2RXkgjO4CnKkjOgI4sKG8NZeVYSTKURf/DFDmHXz7CA29ISyZ9yD0eJDVsMdzqwEP+Z5F KbggtGoUdefcjE+xHOqCSPCIcwdZlBVgVsBCutyof/RGgbmdzOyyJgGOkz1W85gJy9SxTMJtF 0g6UlyyqVeMgI6kByybAq5SKESv9C7fJ3IBcQmdRyhGIOoG8Y2ulLlgwcuoTpnylzA+1TJ5dT QXFEWbqpEbGCOJQiYxq81cBDI+mF9UJOgj2JPzCMXWYR87COzAE/ABhb8jYHnEgOWhxm/2Vim aY8AGGUDaF/VgXVmPx7qRAicXMlbD1XDEtuRRj2JLgOyYZgEPo+Z7ZbO6k7WGsZFTIsgbDe5S vapx8pu6JMmzTQAbQAsOp5P1LWHpWTfB3/AHq4TJpCYlBJCdoNzKb2cOimZzc2uQ3IPLFxkUP w3ZQdNdjidu1JsZu1P7s4iFMalLq+ZZrvjmzMnM45iAc4uOK8KjpaIVq2ASQHqJs2ELcyfYYI kHHwuKmbLEz3aCAWQpvErLi/mHxzUczHIX8VmCUW7iLfGSxEvfI8aQYgQMlbp7jJIg78vjTA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192690 Archived-At: On Wed, 4 Nov 2020 04:02:04 -0800 Stefan Kangas wrote: > Stephen Berman writes: > >> As an aside, do you think that use of the :right-align :pad-right >> properties in timer-list-mode in my first patch is a good change? > > Do you mean this part? > > - (" Next" 12 timer-list--next-predicate) > - (" Repeat" 11 timer-list--repeat-predicate) > + ("Next" 12 timer-list--next-predicate :right-align t :pad-right 1) > + ("Repeat" 11 timer-list--repeat-predicate :right-align t > :pad-right 1) > > If so, it definitely looks like an improvement to me. Do you see any > problems with it? No, and in fact without it the tabulated-list-init-header patch makes selecting "Repeat" column (and hence displaying the sort indicator there) push the "Function" column label to the right, causing misalignment with the data lines; with the properties this does not happen. (However, the width of 11 makes the data lines of the "Repeat" column appear truncated, but this width was changed to 12 in commit 0cb44eed6, fixing that problem.) > BTW, does it work better with narrowing the column, too? We seem to > have some issues with that currently. Do you mean that truncation happens even though there is still enough space to display the data or header? I see that both with hard spaces and with the :right-align property. I haven't tried to figure out why that's happening, but seems to be separate from above change. Given that, and also Eli's approval of the tabulated-list-init-header patch, I've gone ahead and committed these changes. I didn't make any of the column width changes I proposed in my first patch, since with the tabulated-list-init-header patch they don't seem to be needed. Nevertheless, there's clearly still room for improvement, in particular concerning truncation (I also hinted at another problem with this in my last reply to Eli). Steve Berman