From: Stephen Berman <stephen.berman@gmx.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 44068@debbugs.gnu.org
Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format
Date: Wed, 04 Nov 2020 23:53:56 +0100 [thread overview]
Message-ID: <871rh8vim3.fsf@gmx.net> (raw)
In-Reply-To: <CADwFkmkYs9miV2zVqqpUnn1mFpra8A=4CCvPydrxHbxHJk3SWQ@mail.gmail.com> (Stefan Kangas's message of "Wed, 4 Nov 2020 04:02:04 -0800")
On Wed, 4 Nov 2020 04:02:04 -0800 Stefan Kangas <stefankangas@gmail.com> wrote:
> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> As an aside, do you think that use of the :right-align :pad-right
>> properties in timer-list-mode in my first patch is a good change?
>
> Do you mean this part?
>
> - (" Next" 12 timer-list--next-predicate)
> - (" Repeat" 11 timer-list--repeat-predicate)
> + ("Next" 12 timer-list--next-predicate :right-align t :pad-right 1)
> + ("Repeat" 11 timer-list--repeat-predicate :right-align t
> :pad-right 1)
>
> If so, it definitely looks like an improvement to me. Do you see any
> problems with it?
No, and in fact without it the tabulated-list-init-header patch makes
selecting "Repeat" column (and hence displaying the sort indicator
there) push the "Function" column label to the right, causing
misalignment with the data lines; with the properties this does not
happen. (However, the width of 11 makes the data lines of the "Repeat"
column appear truncated, but this width was changed to 12 in commit
0cb44eed6, fixing that problem.)
> BTW, does it work better with narrowing the column, too? We seem to
> have some issues with that currently.
Do you mean that truncation happens even though there is still enough
space to display the data or header? I see that both with hard spaces
and with the :right-align property. I haven't tried to figure out why
that's happening, but seems to be separate from above change.
Given that, and also Eli's approval of the tabulated-list-init-header
patch, I've gone ahead and committed these changes. I didn't make any
of the column width changes I proposed in my first patch, since with the
tabulated-list-init-header patch they don't seem to be needed.
Nevertheless, there's clearly still room for improvement, in particular
concerning truncation (I also hinted at another problem with this in my
last reply to Eli).
Steve Berman
next prev parent reply other threads:[~2020-11-04 22:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 20:00 bug#44068: 28.0.50; Faulty uses of tabulated-list-format Stephen Berman
2020-10-18 21:33 ` Drew Adams
2020-10-18 22:01 ` Stefan Kangas
2020-10-18 22:15 ` Drew Adams
2020-10-18 22:18 ` Stephen Berman
2020-10-18 22:01 ` Stefan Kangas
2020-10-18 22:17 ` Stephen Berman
2020-10-18 22:35 ` Stephen Berman
2020-10-18 23:13 ` Stefan Kangas
2020-10-19 9:04 ` Stephen Berman
2020-10-19 13:52 ` Eli Zaretskii
2020-10-19 18:20 ` Stephen Berman
2020-10-19 18:43 ` Eli Zaretskii
2020-10-19 19:12 ` Stephen Berman
2020-10-20 16:09 ` Stephen Berman
2020-10-29 16:58 ` Stefan Kangas
2020-10-29 22:48 ` Stephen Berman
2020-10-30 1:06 ` Stefan Kangas
2020-10-30 21:44 ` Stephen Berman
2020-10-30 23:51 ` Stefan Kangas
2020-11-01 23:07 ` Stephen Berman
2020-11-02 17:12 ` Eli Zaretskii
2020-11-02 22:37 ` Stephen Berman
2020-11-03 3:27 ` Eli Zaretskii
2020-11-03 23:12 ` Stephen Berman
2020-11-04 15:09 ` Eli Zaretskii
2020-11-04 22:55 ` Stephen Berman
2020-11-04 12:02 ` Stefan Kangas
2020-11-04 22:53 ` Stephen Berman [this message]
2020-11-12 16:38 ` Stefan Kangas
2020-11-12 22:51 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rh8vim3.fsf@gmx.net \
--to=stephen.berman@gmx.net \
--cc=44068@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).