From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string' Date: Thu, 26 Nov 2020 14:12:35 +0100 Message-ID: <871rggs1mk.fsf@gnus.org> References: <6F768DED-2E1B-4D06-A776-FFA162AC32AD@acm.org> <97535AF5-D542-4267-A5A9-1483C32A61AC@acm.org> <83EC926B-DE9E-48BC-8FD2-C7CB3617AD50@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5671"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44861@debbugs.gnu.org, Stefan Kangas , Shigeru Fukaya To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 14:14:47 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiH6k-0001Kl-68 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 14:14:46 +0100 Original-Received: from localhost ([::1]:38542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiH6j-0004iV-7D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 08:14:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiH57-0004hP-KC for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 08:13:13 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiH54-0006nk-DF for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 08:13:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiH54-0006RS-8r for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 08:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 44861-submit@debbugs.gnu.org id=B44861.160639637124745 (code B ref 44861); Thu, 26 Nov 2020 13:13:02 +0000 Original-Received: (at 44861) by debbugs.gnu.org; 26 Nov 2020 13:12:51 +0000 Original-Received: from localhost ([127.0.0.1]:40142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiH4s-0006R3-Mu for submit@debbugs.gnu.org; Thu, 26 Nov 2020 08:12:50 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:50280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiH4q-0006Qp-Lh for 44861@debbugs.gnu.org; Thu, 26 Nov 2020 08:12:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Y8XdtTgFDsBwS2vPW61FBBYfynArKwO1Lsv0YRZLSX8=; b=VVs+qD1sAFhbBYZf2QNchu2dyB WYwMaVRpPF1V8xUHIzpS1JdPJsltrBkW9ApEtHo7mPbFmtZn8H4eAMFv262y5GkamytqAcG/SMq00 kJ0OE7B/wd3uE0swNFHb2yu5OCbKOojjhzpwo0wNMk7X7mSvVpkmThxFmLSVYsPD7zh8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiH4e-0001a7-Vv; Thu, 26 Nov 2020 14:12:42 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEVvja90l8Y6ZZ49 OziJg3iXprT38dn////PMCpNAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QLGgwxNgmIHpEAAAFISURB VDjLpZTBboQgEIYHsvYMdvfu0qQvIH0Cxr23yp43jfL+j9ABQRfUtEn/xBjmY+aHCQDwPzEpxX6Y JFSQD8hMr23QMpuzmn6CM56AAq64uhJQ/t+oBHio1qhrrfzgyt9SKXngUcTl2URw+czBZYhAqEbW qhELsD6uAeoIWJaxgrVUb/aBQIwe1CPq3FLqbLA1Ybl3lzQtGdpkwPmVXzz42AFzRg/Uu3f3oG8F Yesz+H4CcASqsFr0+9gAEzJEYV4NsZTcAB83WwDt7FGVgKXj8VWYzyJyCOrfQB9MO9O5UaM3SuYR DLcJtSmAaXVnraG0EiBir9HkYESk6XbsBsIsN9cab6OmGS0TK6AxItjJTlCdnoHXelAjeKgXN7m7 W6LhKj41McuAorte3gLEFsxXegdEsgHpDSjB8iDYVULC3pPxJ51+ACBzvgDPBT2aAAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIwLTExLTI2VDEyOjQ5OjU0KzAwOjAwNIQCzQAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMC0xMS0yNlQxMjo0OTo1NCswMDowMEXZunEAAAAASUVORK5CYII= X-Now-Playing: Simple Minds's _Sister Feelings Call_: "Careful in Career" In-Reply-To: <83EC926B-DE9E-48BC-8FD2-C7CB3617AD50@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Thu, 26 Nov 2020 13:57:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194311 Archived-At: Mattias Engdeg=C3=A5rd writes: > However, unlike Boris we can eat our cake and have it! The attached > patch performs the match-data translation in a C function, which > obviously is much faster and indeed speeds up replace-regexp-in-string > in all cases (as long as there is any match at all). I'm all for speeding up replace-regexp-in-string (which is used all over the place), so your change looks reasonable to me. But I wonder -- would it make sense to move the entire replace-regexp-in-string function to C? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no