From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Newsgroups: gmane.emacs.bugs Subject: bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code Date: Fri, 05 Feb 2021 11:54:37 +0100 Message-ID: <871rdueqdu.fsf@hajtower> References: <87tuqrtz91.fsf@hajtower> <878s83objc.fsf@gnus.org> <87o8gztqlv.fsf@hajtower> <871rdunb7f.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37496"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 46302@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 05 11:55:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7yla-0009db-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Feb 2021 11:55:10 +0100 Original-Received: from localhost ([::1]:34976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7ylZ-0004eF-H6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Feb 2021 05:55:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7ylS-0004cL-BI for bug-gnu-emacs@gnu.org; Fri, 05 Feb 2021 05:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7ylS-0000Kw-34 for bug-gnu-emacs@gnu.org; Fri, 05 Feb 2021 05:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7ylS-0008MC-2M for bug-gnu-emacs@gnu.org; Fri, 05 Feb 2021 05:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2021 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 46302-submit@debbugs.gnu.org id=B46302.161252248932102 (code B ref 46302); Fri, 05 Feb 2021 10:55:02 +0000 Original-Received: (at 46302) by debbugs.gnu.org; 5 Feb 2021 10:54:49 +0000 Original-Received: from localhost ([127.0.0.1]:42956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ylF-0008Li-84 for submit@debbugs.gnu.org; Fri, 05 Feb 2021 05:54:49 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:56567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ylC-0008LU-3c for 46302@debbugs.gnu.org; Fri, 05 Feb 2021 05:54:47 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id BD3D7240103 for <46302@debbugs.gnu.org>; Fri, 5 Feb 2021 11:54:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1612522478; bh=dTmWvKUmGhiPQ9U3beph6OHxKcFE0pnCDKexu08Em1w=; h=From:To:Cc:Subject:Date:From; b=WZScHoftQK43BfBOzj9D8IHEKBpxzy+fFQVMZw+FQQ953gzxuZ4j2yNH48+0pokVf rU8HzvN6bt05PX8/A2yhjiLJ6yXxTkCtIvrBoPO3b/zZ3v6Q5+grPiB2hNQr/M5kkv WWbo4vFEH7z2OSdO11ZzTZdfUlOEzdMqu+s7rxlaDgBse4My3CmYiCcfWCLVC11rc8 vWiBAxHsxX0BXGhPkbya4m44Rp2SJI3DtEQzgys03DGcPQmQntw7ZhwGJ3WLVFASe/ OUL82Vj3vHOforIvX/yrG7nOo34zUfXz7kEUmXiIJvwhf85DaC3rtW8E8108IL2vHL SNMoE73l6VY+Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DXC3d5dCFz6tmV; Fri, 5 Feb 2021 11:54:37 +0100 (CET) In-Reply-To: <871rdunb7f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 05 Feb 2021 09:57:40 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199355 Archived-At: Lars Ingebrigtsen writes: >> Isn't `make-obsolete-variable` supposed to generate a compiler warning? > > It is supposed to, but somehow it didn't... [...] > > Hm... perhaps it's because of this? > > - (if cperl-use-syntax-table-text-property > - (if (eval-when-compile (fboundp 'syntax-propertize-rules)) > - (progn > > And the compiler got confused and didn't output a warning (always)? Ah, that reminds me of something... I did the elimination in several steps, and in one of them killed the conditional and the if-branch, but forget to kill the else-branch as well. Apparently I ran the first compilation test with that (bogus) intermediate version, and got the warning. As it turns out, the byte compiler shortcuts the conditional if it eval-when-compiles to a constant and doesn't even touch the else-branch. Digging into the commit logs reveals: commit 4813c453b22ff7b965e31a30d35b70f73d6bcbc7 Author: Stefan Monnier Date: Sun Feb 3 10:47:12 2013 -0500 * lisp/progmodes/cperl-mode.el (cperl-mode): Avoid byte-compile warning. Now it all makes sense :) -- Cheers, haj