From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Wed, 10 Mar 2021 22:13:55 +0200 Message-ID: <871rcmojgc.fsf@protesilaos.com> References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> <87h7lofe6b.fsf@protesilaos.com> <87mtvfpgf2.fsf@protesilaos.com> <878s6wqq40.fsf@tcd.ie> <874khk6t7d.fsf@protesilaos.com> <87mtvb1s3r.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25949"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46964@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 10 21:15:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK5FF-0006cp-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 21:15:49 +0100 Original-Received: from localhost ([::1]:39988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK5FE-00025O-Gz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 15:15:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK5EU-0001nZ-K8 for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 15:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40393) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK5EU-0000Ti-9m for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 15:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lK5EU-00074t-5d for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 15:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.161540724727123 (code B ref 46964); Wed, 10 Mar 2021 20:15:02 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 10 Mar 2021 20:14:07 +0000 Original-Received: from localhost ([127.0.0.1]:51937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK5Da-00073P-Tc for submit@debbugs.gnu.org; Wed, 10 Mar 2021 15:14:07 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:60967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK5DZ-00072i-Hc for 46964@debbugs.gnu.org; Wed, 10 Mar 2021 15:14:06 -0500 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 0D0A6240003; Wed, 10 Mar 2021 20:13:57 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 10 Mar 2021 13:41:24 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202035 Archived-At: On 2021-03-10, 13:41 -0500, Stefan Monnier wrote: > Hmm... I made further changes to elpa-admin.el to handle this case. > Here were the problems I encountered: > - The .texi file generated by Org was basically empty because the .org > file that Org saw was literally empty (a symlink pointing nowhere), > because the `emacs` subdir was not included in the sandbox. > - After adding the `emacs` subdir to the sandbox the problem was that > Emacs followed the symlink to the `emacs` subdir and then Org > tried to generate ../emacs/doc/misc/modus-themes.texi into > ../packages/modus-themes/modus-themes.texi. > - After preventing Emacs to follow symlinks Org generated a proper .texi > but makeinfo complained of a missing doclicense.texi, so I had to add > "doc/misc/doclicense.texi" to the :core keyword. > > I believe it should work now. Please try again, Thank you! I confirm that the package builds correctly. How do we proceed from here? In my original patch, I intended to outright delete 'modus-{operandi,vivendi}-theme'. Though you noted the possibility of making those old packages pull in the new one. I am fine either way. -- Protesilaos Stavrou protesilaos.com