unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>, 46964@debbugs.gnu.org
Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core
Date: Wed, 10 Mar 2021 22:13:55 +0200	[thread overview]
Message-ID: <871rcmojgc.fsf@protesilaos.com> (raw)
In-Reply-To: <jwvsg52sx0l.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 10 Mar 2021 13:41:24 -0500")

On 2021-03-10, 13:41 -0500, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Hmm... I made further changes to elpa-admin.el to handle this case.
> Here were the problems I encountered:
> - The .texi file generated by Org was basically empty because the .org
>   file that Org saw was literally empty (a symlink pointing nowhere),
>   because the `emacs` subdir was not included in the sandbox.
> - After adding the `emacs` subdir to the sandbox the problem was that
>   Emacs followed the symlink to the `emacs` subdir and then Org
>   tried to generate ../emacs/doc/misc/modus-themes.texi into
>   ../packages/modus-themes/modus-themes.texi.
> - After preventing Emacs to follow symlinks Org generated a proper .texi
>   but makeinfo complained of a missing doclicense.texi, so I had to add
>   "doc/misc/doclicense.texi" to the :core keyword.
>
> I believe it should work now.  Please try again,

Thank you!  I confirm that the package builds correctly.

How do we proceed from here?  In my original patch, I intended to
outright delete 'modus-{operandi,vivendi}-theme'.  Though you noted the
possibility of making those old packages pull in the new one.  I am fine
either way.

-- 
Protesilaos Stavrou
protesilaos.com





  reply	other threads:[~2021-03-10 20:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 11:58 bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Protesilaos Stavrou
2021-03-06 14:39 ` Basil L. Contovounesios
2021-03-06 15:00   ` Stefan Monnier
2021-03-06 16:19     ` Protesilaos Stavrou
2021-03-06 18:35       ` Stefan Monnier
2021-03-07  7:32         ` Protesilaos Stavrou
2021-03-09 15:54           ` Basil L. Contovounesios
2021-03-09 16:46             ` Stefan Monnier
2021-03-09 19:08             ` Protesilaos Stavrou
2021-03-09 20:49               ` Stefan Monnier
2021-03-10  3:48                 ` Stefan Monnier
2021-03-10  5:43                   ` Protesilaos Stavrou
2021-03-10 18:41                     ` Stefan Monnier
2021-03-10 20:13                       ` Protesilaos Stavrou [this message]
2021-03-10 23:17                         ` Stefan Monnier
2021-03-10 23:23                           ` Basil L. Contovounesios
2021-03-11  3:07                             ` Stefan Monnier
2021-03-11  8:27                               ` Protesilaos Stavrou
2021-03-11 19:45                                 ` Basil L. Contovounesios
2021-03-11 22:54                                 ` Stefan Monnier
2021-03-12  7:59                                   ` Protesilaos Stavrou
2021-03-13 17:10                           ` Stefan Monnier
2021-03-17  7:04                             ` Protesilaos Stavrou
2021-03-18  7:55                               ` Protesilaos Stavrou
2021-03-18 17:52                                 ` Stefan Monnier
2021-03-19  5:29                                   ` Protesilaos Stavrou
2021-03-19 12:55                                     ` Stefan Monnier
2021-03-19 14:18                                       ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rcmojgc.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=46964@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).