From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47012: xref copies keymap properties to minibuffer Date: Thu, 25 Mar 2021 11:40:05 +0200 Organization: LINKOV.NET Message-ID: <871rc3bls6.fsf@mail.linkov.net> References: <87czw9tnu9.fsf@mail.linkov.net> <3aad442a-7319-5db5-2fc6-560bb032c34d@yandex.ru> <87a6r9v24b.fsf@mail.linkov.net> <87sg4kb839.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33388"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 47012@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 25 11:04:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPMqq-0008X6-TG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Mar 2021 11:04:28 +0100 Original-Received: from localhost ([::1]:39392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPMqp-00079J-Tq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Mar 2021 06:04:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPMkc-0003en-PP for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 05:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPMkc-0002j9-Hd for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 05:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPMkc-0005si-Gt for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 05:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Mar 2021 09:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47012 X-GNU-PR-Package: emacs Original-Received: via spool by 47012-submit@debbugs.gnu.org id=B47012.161666625022552 (code B ref 47012); Thu, 25 Mar 2021 09:58:02 +0000 Original-Received: (at 47012) by debbugs.gnu.org; 25 Mar 2021 09:57:30 +0000 Original-Received: from localhost ([127.0.0.1]:37180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPMk6-0005rb-6q for submit@debbugs.gnu.org; Thu, 25 Mar 2021 05:57:30 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:52441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPMk4-0005qt-Al for 47012@debbugs.gnu.org; Thu, 25 Mar 2021 05:57:28 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 061ED100012; Thu, 25 Mar 2021 09:57:20 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Wed, 24 Mar 2021 23:57:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202994 Archived-At: >> Actually, can't do this without feature request, >> and can't use it as is, because never use regexp >> while searching in project, whereas it pollutes >> the regexp history for commands where I really >> use regexps, not just strings. >> A simple patch could be a saver to use with e.g. >> (setq project-regexp-history-variable 'minibuffer-history): > > The idea makes sense, but perhaps we shouldn't add one more way of doing > this and just copy what grep-read-regexp does. Meaning, define > a project-specific var and then use it. We could use 'grep-regexp-history > there too, as another alternative. > > But having a var called project-regexp-history seems more powerful, and > even no less powerful than your suggested approach, because one can always > turn that variable into a defalias, if they so wish. Sharing regexp history between grep and project-find-regexp would be the most desirable. How better to achieve this? Some commands already use variable *-history-variable, so adding project-regexp-history-variable wouldn't cause a new precedent. Whereas using defalias is something new, maybe it could work too: (defalias 'grep-regexp-history 'project-regexp-history)