From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47012: xref copies keymap properties to minibuffer Date: Thu, 25 Mar 2021 23:28:34 +0200 Organization: LINKOV.NET Message-ID: <871rc2ly7x.fsf@mail.linkov.net> References: <87czw9tnu9.fsf@mail.linkov.net> <3aad442a-7319-5db5-2fc6-560bb032c34d@yandex.ru> <87a6r9v24b.fsf@mail.linkov.net> <87sg4kb839.fsf@mail.linkov.net> <871rc3bls6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4049"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 47012@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 25 22:30:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPXYS-0000yJ-RA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Mar 2021 22:30:12 +0100 Original-Received: from localhost ([::1]:34304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPXYR-0006za-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Mar 2021 17:30:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPXYJ-0006z4-6k for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 17:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPXYI-0004h8-Sn for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 17:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPXYI-0003SS-O6 for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Mar 2021 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47012 X-GNU-PR-Package: emacs Original-Received: via spool by 47012-submit@debbugs.gnu.org id=B47012.161670777813235 (code B ref 47012); Thu, 25 Mar 2021 21:30:02 +0000 Original-Received: (at 47012) by debbugs.gnu.org; 25 Mar 2021 21:29:38 +0000 Original-Received: from localhost ([127.0.0.1]:39755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPXXu-0003RP-AJ for submit@debbugs.gnu.org; Thu, 25 Mar 2021 17:29:38 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:53671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPXXr-0003R9-HQ for 47012@debbugs.gnu.org; Thu, 25 Mar 2021 17:29:36 -0400 X-Originating-IP: 91.129.107.223 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D692D40007; Thu, 25 Mar 2021 21:29:27 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Thu, 25 Mar 2021 12:57:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203030 Archived-At: >> Sharing regexp history between grep and project-find-regexp would be >> the most desirable. How better to achieve this? > > Either by using 'grep-regexp-history directly, or with either of the > options below. > >> Some commands already use variable *-history-variable, so adding >> project-regexp-history-variable wouldn't cause a new precedent. > > Could you give an example? What I tried is C-h v *-history-variable TAB minibuffer-history-variable query-replace-from-history-variable query-replace-to-history-variable y-or-n-p-history-variable Maybe other commands use another suffix (probably not). > And ideally, we should be also able to answer the question why some > packages have their own variables, and others have "-variable variables". I don't know. > If it's just historical reasons, as it often is, maybe > > (defvar project-regexp-history-variable 'grep-regexp-history) > > will be good enough. This would a good thing to do. >> Whereas using defalias is something new, maybe it could work too: >> (defalias 'grep-regexp-history 'project-regexp-history) > > Yup, that's what I meant. It does feel a bit hackish, though. > > Another possible approach would be some categories based system, together > with user customization, like completion-category-overrides, but it's > probably overkill for this problem. I agree on both these statements.