From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Wed, 14 Apr 2021 23:21:08 +0300 Organization: LINKOV.NET Message-ID: <871rbcr51n.fsf@mail.linkov.net> References: <87pmz8lc17.fsf@mail.linkov.net> <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> <87o8eo38q9.fsf@mail.linkov.net> <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> <87eefh9176.fsf@mail.linkov.net> <5c7b677f-0f4a-bbef-8c1f-42cd024c7314@yandex.ru> <87czuzxysf.fsf@mail.linkov.net> <874kg9mj7f.fsf@gmail.com> <87h7k8n3uy.fsf@mail.linkov.net> <87tuo8of2g.fsf_-_@gmail.com> <87im4or6df.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12636"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , Ramesh Nedunchezian , 47566@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 14 22:24:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWm3c-00038m-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 22:24:16 +0200 Original-Received: from localhost ([::1]:35744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWm3b-0001Rv-Oa for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 16:24:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWm3O-0001O4-6a for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 16:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWm3N-0008Ht-V8 for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 16:24:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWm3N-0008Fo-Rx for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 16:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Apr 2021 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-submit@debbugs.gnu.org id=B47566.161843179331671 (code B ref 47566); Wed, 14 Apr 2021 20:24:01 +0000 Original-Received: (at 47566) by debbugs.gnu.org; 14 Apr 2021 20:23:13 +0000 Original-Received: from localhost ([127.0.0.1]:35838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWm2a-0008El-Qz for submit@debbugs.gnu.org; Wed, 14 Apr 2021 16:23:13 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:54483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWm2Y-0008EW-NY for 47566@debbugs.gnu.org; Wed, 14 Apr 2021 16:23:11 -0400 X-Originating-IP: 91.129.96.157 Original-Received: from mail.gandi.net (m91-129-96-157.cust.tele2.ee [91.129.96.157]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 52E11FF80B; Wed, 14 Apr 2021 20:23:01 +0000 (UTC) In-Reply-To: <87im4or6df.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Apr 2021 22:52:28 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204032 Archived-At: >> Also, AFAICT the indication (whether in the mode-line or in the echo >> area) only shows up once I start repeating a key (e.g. after C-x o o), >> not when I first hit a repeatable key (e.g. after C-x o). > > Strange, I see it immediately after C-x o. Could you please try to move 'force-mode-line-update' out of condition, so it updates the mode-line on activating the repeat map as well: #+begin_src emacs-lisp (defun repeat-echo-mode-line (map) "Display the repeat indicator in the mode line." (if map (unless (assq 'repeat-in-progress mode-line-modes) (add-to-list 'mode-line-modes (list 'repeat-in-progress repeat-echo-mode-line-string)))) (force-mode-line-update t)) #+end_src Maybe your mode-line is not updated immediately?