From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 03/15] Add and use BUFFER_DEFAULT_VALUE_P Date: Fri, 07 May 2021 10:30:51 -0400 Message-ID: <871rair4ys.fsf@catern.com> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-4-sbaugh@catern.com> <83czu3c88w.fsf@gnu.org> <87tuner9mw.fsf@catern.com> <83wnsabt00.fsf@gnu.org> <87a6p6r7eb.fsf@catern.com> <83lf8qbqyj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18049"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 16:31:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf1Vl-0004bf-QM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 16:31:25 +0200 Original-Received: from localhost ([::1]:54864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf1Vk-0003MY-RE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 10:31:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf1VO-0003Lu-Fr for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf1VO-0001MN-89 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf1VO-0007Tx-3c for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039785428741 (code B ref 48264); Fri, 07 May 2021 14:31:02 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 14:30:54 +0000 Original-Received: from localhost ([127.0.0.1]:44274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf1VG-0007TV-AW for submit@debbugs.gnu.org; Fri, 07 May 2021 10:30:54 -0400 Original-Received: from venus.catern.com ([68.183.49.163]:33728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf1VE-0007TO-Jw for 48264@debbugs.gnu.org; Fri, 07 May 2021 10:30:53 -0400 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1620397852; bh=4Av4wq2LJFpBPzqi7ZynhBJ4AMbrpRpXF/DvipR1034=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=FiBpge9DfPXwv4Tq4Y9BsOk/MvbhcfUlptObw/Ex2Lr2IH6ltvwQQDHM6nDz+cU1g y/+X7JiMyGGs0sFteQ6IcRcL9pcN8JeOBzSIRMq+3cQ0iVzhCVwQyskWegBVnQfsAF RJOix7Y11hUPNy8w08nfssP2N7tZE3Wi3ZorhjMo= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 327FD2E4579; Fri, 7 May 2021 14:30:52 +0000 (UTC) In-Reply-To: <83lf8qbqyj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205946 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: 48264@debbugs.gnu.org >> Date: Fri, 07 May 2021 09:38:20 -0400 >> >> > It's the other way around here: the test "if (idx > 0)" is clear, >> > whereas "if (BUFFER_DEFAULT_VALUE_P (offset))" makes me go look up the >> > definition of the macro, because the name is not expressive enough, >> > and the argument "offset" doesn't help, either. >> >> Sure; what about the name "BUFFER_VAR_HAS_DEFAULT_VALUE_P"? > > Much better. Maybe BVAR_HAS_DEFAULT_VALUE_P? it's shorter. Will change to that - with that change, is this patch fine, or would you still prefer comments on the usage sites?