bug#20457: compiler does not warn about arglist mismatch with obsolete alias

bug#20457: compiler does not warn about arglist mismatch with obsolete alias

[Glenn Morris]

Package: emacs
Version: 24.5

Byte-compiling the following:
    
    (defun newfunc ()
      t)
    
    (eval-and-compile
      (define-obsolete-function-alias 'oldfunc 'newfunc "25.1"))
    
    (defun blah ()
      (oldfunc t))

warns about oldfunc being obsolete:
  
  In blah:
  foo.el:6:8:Warning: `oldfunc' is an obsolete function (as of 25.1); use
      `newfunc' instead.

however, it says nothing about blah calling oldfunc with the wrong
number of arguments, which leads to a runtime error.

bug#20457: compiler does not warn about arglist mismatch with obsolete alias

[Marcin Borkowski]

On 2015-04-29, at 03:08, Glenn Morris <rgm@gnu.org> wrote:

> Package: emacs
> Version: 24.5
>
> Byte-compiling the following:
>     
>     (defun newfunc ()
>       t)
>     
>     (eval-and-compile
>       (define-obsolete-function-alias 'oldfunc 'newfunc "25.1"))
>     
>     (defun blah ()
>       (oldfunc t))
>
> warns about oldfunc being obsolete:
>   
>   In blah:
>   foo.el:6:8:Warning: `oldfunc' is an obsolete function (as of 25.1); use
>       `newfunc' instead.
>
> however, it says nothing about blah calling oldfunc with the wrong
> number of arguments, which leads to a runtime error.

Confirmed on GNU Emacs 25.1.50.8 (1e8cd05).

Best,

-- 
Marcin

bug#20457: compiler does not warn about arglist mismatch with obsolete alias

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> warns about oldfunc being obsolete:
>
>   In blah:
>   foo.el:6:8:Warning: `oldfunc' is an obsolete function (as of 25.1); use
>       `newfunc' instead.
>
> however, it says nothing about blah calling oldfunc with the wrong
> number of arguments, which leads to a runtime error.

The problem seems to be more general than that -- it doesn't warn about
the wrong number of arguments, ever, if using aliases?

Test case:

(defun foo ())
(defalias 'bar 'foo)
(defun zot ()
  (bar t))
(defun foobar ()
  (foo t))


----
Compiling file /tmp/warn.el at Fri May 28 02:26:55 2021

In foobar:
warn.el:6:4: Warning: foo called with 1 argument, but accepts only 0
----

Note -- no warning from the zot function.

It seems so odd that nobody has pointed this out before, so I'm
wondering if I'm just doing something obviously wrong in this test
case.  Anybody?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#20457: compiler does not warn about arglist mismatch with obsolete alias

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Fri, 28 May 2021 02:30:38 +0200
> Cc: 20457@debbugs.gnu.org
> 
> Glenn Morris <rgm@gnu.org> writes:
> 
> > warns about oldfunc being obsolete:
> >
> >   In blah:
> >   foo.el:6:8:Warning: `oldfunc' is an obsolete function (as of 25.1); use
> >       `newfunc' instead.
> >
> > however, it says nothing about blah calling oldfunc with the wrong
> > number of arguments, which leads to a runtime error.
> 
> The problem seems to be more general than that -- it doesn't warn about
> the wrong number of arguments, ever, if using aliases?
> 
> Test case:
> 
> (defun foo ())
> (defalias 'bar 'foo)
> (defun zot ()
>   (bar t))
> (defun foobar ()
>   (foo t))
> 
> 
> ----
> Compiling file /tmp/warn.el at Fri May 28 02:26:55 2021
> 
> In foobar:
> warn.el:6:4: Warning: foo called with 1 argument, but accepts only 0
> ----
> 
> Note -- no warning from the zot function.
> 
> It seems so odd that nobody has pointed this out before, so I'm
> wondering if I'm just doing something obviously wrong in this test
> case.  Anybody?

Stefan?

bug#20457: compiler does not warn about arglist mismatch with obsolete alias

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> The problem seems to be more general than that -- it doesn't warn about
>> the wrong number of arguments, ever, if using aliases?
>> 
>> Test case:
>> 
>> (defun foo ())
>> (defalias 'bar 'foo)
>> (defun zot ()
>>   (bar t))
>> (defun foobar ()
>>   (foo t))
>>
>>
>> ----
>> Compiling file /tmp/warn.el at Fri May 28 02:26:55 2021
>> 
>> In foobar:
>> warn.el:6:4: Warning: foo called with 1 argument, but accepts only 0
>> ----
>> 
>> Note -- no warning from the zot function.
>> 
>> It seems so odd that nobody has pointed this out before, so I'm
>> wondering if I'm just doing something obviously wrong in this test
>> case.  Anybody?
>
> Stefan?

The byte-compiler's tracking of functions arity is quite limited, yes.
Patches to improve it are welcome.


        Stefan