From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49449: 28: TLS connection never gets to "open" stage Date: Sun, 11 Jul 2021 13:31:10 +0200 Message-ID: <871r85m6ip.fsf@gnus.org> References: <87lf6h3nj0.fsf@gnus.org> <22155A42-4A01-4EF1-80BC-B9CDE31ED0B1@acm.org> <87o8bdt180.fsf@gnus.org> <875yxip21h.fsf@gnus.org> <875yxinm2e.fsf@gnus.org> <3B256E70-EBA5-4981-BB84-AE7A4B9DD459@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7226"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49449@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 11 13:32:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2Xgv-0001jh-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Jul 2021 13:32:09 +0200 Original-Received: from localhost ([::1]:47322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2Xgu-0001AD-OK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Jul 2021 07:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2Xgo-00018f-IU for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 07:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2Xgo-0007Ia-9x for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 07:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2Xgo-00068g-8I for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jul 2021 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49449 X-GNU-PR-Package: emacs Original-Received: via spool by 49449-submit@debbugs.gnu.org id=B49449.162600308922011 (code B ref 49449); Sun, 11 Jul 2021 11:32:02 +0000 Original-Received: (at 49449) by debbugs.gnu.org; 11 Jul 2021 11:31:29 +0000 Original-Received: from localhost ([127.0.0.1]:33992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2XgG-0005ih-V5 for submit@debbugs.gnu.org; Sun, 11 Jul 2021 07:31:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2XgF-0005db-Sg for 49449@debbugs.gnu.org; Sun, 11 Jul 2021 07:31:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3VMjtXQW3ZHUedzCMRSZPWCZqDyYOxzczgsF3tNP2rI=; b=VQNPqj+2G+rWAbxzoHuSpLQdgw tw9lGrA+Qx7xm9fLGw70IZnwSkSeaUVAQey80mOx7wYatc/3y+ZwAyK8EemtRNA8LpHAtni2Qrgoy IKK0nK8M2CAfN8PJFMQJpGM9PU0lrHyIPfO8TBOacbLyXCFspyLEs1ovRh7ETB2AbBrU=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2Xfz-00029m-0r; Sun, 11 Jul 2021 13:31:21 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUQDQwgHRxBPj0v LSyPjYxvbGshIB6hn51NTEvBv761s7L6+fnQ0M6Bf33////E5CGhAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UHCwsdDWL0hMAAAAEHSURBVDjLY2AYnIARRDAJYJdhZHbEIgFW7AqlMWTSHeBqUI3jmIzD dualCZgSYANCsbkLBISbcUikuDNil+CqMMAuw7E0DGIZczCaZ0LAPmFgXtWAKpGQtRiscXUAuvfZ jwAtYZ29hVEQ3ZJVBgwsp3cvQLc8dXF0W+vq3XvQ/dm+e6v1ntO7d6HZzNCze/f27t27jxigGR8R PWtKdM/uqRjm3GgWYOgOdUa3l22JmgADY/UEeBzAQGsgiLy9GV2DKFicIWcLugTURhYML8CcttsB uwTD6m04JGy24pBg2YNDgm12A4YYxFvdC3BoYd2MQ4JhOi4JLgMcEhwBuLSE4ZJIZhjkAAD1ITez DQxRlAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wNy0xMVQxMToyOToxMyswMDowMGHmY1AAAAAl dEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDctMTFUMTE6Mjk6MTMrMDA6MDAQu9vsAAAAAElFTkSuQmCC X-Now-Playing: Burial's _Tunes 2011-2019 (1)_: "Night Market" In-Reply-To: <3B256E70-EBA5-4981-BB84-AE7A4B9DD459@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sat, 10 Jul 2021 22:05:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209793 Archived-At: Mattias Engdeg=C3=A5rd writes: > Here is a slightly more principled solution. It blocks attempts at TLS > handshaking until the nonblocking connect has actually been > established, since it's pointless to go on beforehand. [...] > - && p->is_non_blocking_client) > + && p->is_non_blocking_client > + /* Don't proceed until we have established a connection. */ > + && !(fd_callback_info[p->outfd].flags > + & NON_BLOCKING_CONNECT_FD)) Yeah, I think that's a sensible change (but I haven't tried it). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no