From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christopher League Newsgroups: gmane.emacs.bugs Subject: bug#49725: [PATCH] Unfontify previous location when overwriting bookmark Date: Sun, 25 Jul 2021 10:18:43 -0400 Message-ID: <871r7mlbng.fsf@contrapunctus.net> References: <875ywzkzie.fsf@contrapunctus.net> <87wnpex2py.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34738"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49725@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 16:19:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7eyE-0008ph-LW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 16:19:10 +0200 Original-Received: from localhost ([::1]:52852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7eyD-0006ua-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 10:19:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7ey7-0006rT-9N for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 10:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7ey7-0004pL-17 for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 10:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7ey6-0005hZ-F2 for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christopher League Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49725-submit@debbugs.gnu.org id=B49725.162722273421902 (code B ref 49725); Sun, 25 Jul 2021 14:19:02 +0000 Original-Received: (at 49725) by debbugs.gnu.org; 25 Jul 2021 14:18:54 +0000 Original-Received: from localhost ([127.0.0.1]:49090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7exy-0005hC-2r for submit@debbugs.gnu.org; Sun, 25 Jul 2021 10:18:54 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:57575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7exv-0005gx-Rm for 49725@debbugs.gnu.org; Sun, 25 Jul 2021 10:18:52 -0400 Original-Received: (Authenticated sender: league@contrapunctus.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 97141C0002; Sun, 25 Jul 2021 14:18:44 +0000 (UTC) In-Reply-To: <87wnpex2py.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210713 Archived-At: Lars Ingebrigtsen writes: > Thanks; looks good to me (and pushed to Emacs 28). Does this > also fix the related bug#49645? Oh, I missed that! Found the discussion from May, but not that report a few days ago. I think it must fix that, though Marius describes that the highlighting gets stuck "when deleting bookmarks", which I think was working before my patch, which only applies to overwrites. >From what I can tell, the call to =E2=80=98bookmark--unfontify=E2=80=99 ins= ide =E2=80=98bookmark-delete=E2=80=99 dates to 4 May, in the same commit when =E2=80=98bookmark-fontify=E2=80=99 option was introduced. But maybe he was accumulating bookmarks due to overwrites and misattributed it. I'll reply on that report to confirm. CL