From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Sun, 15 Aug 2021 19:12:57 +0300 Organization: LINKOV.NET Message-ID: <871r6u66zm.fsf@mail.linkov.net> References: <87pmufb3u0.fsf@mail.linkov.net> <87tujqoram.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4057"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 50067@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 15 18:22:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFIu5-0000wZ-NW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Aug 2021 18:22:29 +0200 Original-Received: from localhost ([::1]:34424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFIu4-0001SK-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Aug 2021 12:22:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFIte-000146-Ht for bug-gnu-emacs@gnu.org; Sun, 15 Aug 2021 12:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFIte-0007sH-BZ for bug-gnu-emacs@gnu.org; Sun, 15 Aug 2021 12:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFIte-0003i1-88 for bug-gnu-emacs@gnu.org; Sun, 15 Aug 2021 12:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Aug 2021 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162904447714163 (code B ref 50067); Sun, 15 Aug 2021 16:22:02 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 15 Aug 2021 16:21:17 +0000 Original-Received: from localhost ([127.0.0.1]:47619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFIsv-0003gM-Gm for submit@debbugs.gnu.org; Sun, 15 Aug 2021 12:21:17 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:45693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFIss-0003g4-Dx for 50067@debbugs.gnu.org; Sun, 15 Aug 2021 12:21:16 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 2A494100004; Sun, 15 Aug 2021 16:21:06 +0000 (UTC) In-Reply-To: <87tujqoram.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 15 Aug 2021 13:56:01 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211929 Archived-At: > I haven't tested the branch, but reading the diff, it looks like an > excellent feature to me. Looking at the implementation of the stuff in > various modes, I'm wondering whether the interface should perhaps be > tweaked a bit: > > +(defun eww-context-menu (menu) > [...] > + (when (or (mouse-posn-property (event-start last-input-event) 'shr-url) > + (mouse-posn-property (event-start last-input-event) 'image-url)) > + (define-key menu [shr-mouse-browse-url-new-window] > > Perhaps the signature of the context menu functions should be: > > +(defun eww-context-menu (menu event) > > ? To get an event would be nice, but I see no way to do this. The top function 'context-menu-map' is called by: `(menu-item ,(purecopy "Context Menu") ignore :filter (lambda (_) (context-menu-map)))) that has no access to the event - an unused argument of lambda above is just the binding that is 'ignore' in this case. > I'm also wondering whether we should add a `context-menu' text property. As soon as such a need arises, a text property could be added as well. But it seems currently much cleaner is to use a single context-menu function for every mode.