unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50178@debbugs.gnu.org
Subject: bug#50178: 28.0.50; Size of echo area does not account for line-spacing
Date: Tue, 24 Aug 2021 20:38:56 +0200	[thread overview]
Message-ID: <871r6ig01r.fsf@telefonica.net> (raw)
In-Reply-To: <83y28qvhhn.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Aug 2021 21:13:08 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> IMAO the case where the user wants to ensure that the mini window is
>> capable of displaying at least X lines is much more common than the user
>> wanting a height of at least X times the default font's height.
>
> But the former is basically impossible to provide, not in Emacs 21+
> with its support for variable-size fonts and display of images and
> xwidgets as part of text.  Even with just different fonts, N lines
> using font of size X are not the same as N lines with size Y.

We are talking about the mini window here. It's contents are much more
restricted, in the sense that it is determined by some command. This bug
report is about such command wanting to show at least N lines, using the
current display settings (font, line spacing, etc).

>> You can't navigate around on the contents of the mini-window.
>
> ??? Of course, I can.  What do you mean by "you can't"?  The
> mini-window is just another window, so as long as you can make it the
> selected window (e.g., when the minibuffer is active), you can
> navigate there.

Allowing the user to move around on the mini window possibly is at odds
with the UI of the command using the mini window. Certainly, it would be
an inconvenience, as I mentioned before.

>> If a
>> package can't rely on setting max-mini-window-height for showing certain
>> number of lines on the mini-window, then it must implement vertical
>> scrolling, which makes things complex both on the programming side and
>> on the UI side, just to make sure that the user can access the content's
>> of the overflowing line(s), if any.
>
> The recipe you show in the bug report does support scrolling: the up-
> and down-arrow keys scroll the list of candidates.

Yes, that was just an example for demonstrating the problem using stock
Emacs.

Curiously, something like

(message "foo1\nfoo2\nfoo3\nfoo4\nfoo4\nfoo5\nfoo6\nfoo7\nfoo8")

doesn't show truncated lines because it apparently ignores the value of
line-spacing.

> There was no ido-grid-mode in the original report, so I guess you are
> now talking about a different recipe?  Can you present it?  We could
> then discuss those problems and what can be done about that.

ido-grid-mode does not support vertical scrolling (it is not supposed to
do that and it would be a burden if it did) and with certain values of
line-spacing the last line(s) are partially visible or invisible. It's
as simple as that. It uses max-mini-window-height for ensuring that the
text fits on the mini-window, but that doesn't work on the presence of
line-spacing.

One workround would be to locally set line-spacing to nil (overriding
the user's preferences), but this does not protect against other current
or future settings that might affect how the lines are rendered.





  reply	other threads:[~2021-08-24 18:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  2:08 bug#50178: 28.0.50; Size of echo area does not account for line-spacing Óscar Fuentes
2021-08-24 11:58 ` Eli Zaretskii
2021-08-24 13:34   ` Óscar Fuentes
2021-08-24 16:20     ` Eli Zaretskii
2021-08-24 17:44       ` Óscar Fuentes
2021-08-24 18:13         ` Eli Zaretskii
2021-08-24 18:38           ` Óscar Fuentes [this message]
2021-08-24 18:49             ` Eli Zaretskii
2021-08-24 19:36               ` Óscar Fuentes
2021-08-25  2:24                 ` Eli Zaretskii
2021-08-25  7:49                   ` martin rudalics
2021-08-25  9:01                     ` Gregory Heytings
2021-08-25 10:49                     ` Óscar Fuentes
2021-08-25 12:15                       ` Eli Zaretskii
2021-08-25 14:33                       ` Gregory Heytings
2021-08-25 17:09                         ` Óscar Fuentes
2021-08-25 17:57                           ` Eli Zaretskii
2021-08-25 20:10                             ` Óscar Fuentes
2021-08-26  6:34                               ` Eli Zaretskii
2021-08-26  7:54                       ` martin rudalics
2021-08-26  8:12                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r6ig01r.fsf@telefonica.net \
    --to=ofv@wanadoo.es \
    --cc=50178@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).