unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "Michalis V." <mvar.40k@gmail.com>, 11912@debbugs.gnu.org
Subject: bug#11912: 24.1; 'M' in Dired on a symlink does not refresh the display
Date: Wed, 25 Aug 2021 12:57:56 +0200	[thread overview]
Message-ID: <871r6hn64r.fsf@gnus.org> (raw)
In-Reply-To: <8678ec5a-a5f2-8ae4-6212-c377c3abe9e8@cs.ucla.edu> (Paul Eggert's message of "Tue, 24 Aug 2021 10:32:01 -0700")

Paul Eggert <eggert@cs.ucla.edu> writes:

> * I neglected to document this behavior change, so I just now
>   installed the attached to fix that oversight.

I understand the security-related reasons for changing the `M' command,
but I'm wondering whether they are weighty enough to make it more
inconvenient for the user to use symlinks in Emacs.

The reasoning is that an attacker may control a symlink and make it
point to somewhere else.  So I may have 

  lrwxrwxrwx  1 evil      evil         17 Aug 25 12:52 foosym -> /tmp/IMG_4475.JPG

in my dired buffer, and then "evil" changes the link to point to
somewhere else, and then I say `M' on the link, and then I operated on
the wrong file.

However, on the command line, chmod is fine with following symlinks, so
the user can just `! chmod 0444' instead, and the same will happen.

So is inconveniencing people who are using the `M' command worth it?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-08-25 10:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 16:30 bug#11912: 24.1; 'M' in Dired on a symlink does not refresh the display Eli Zaretskii
2021-08-24 10:23 ` Michalis V.
2021-08-24 15:40   ` Lars Ingebrigtsen
2021-08-24 17:32     ` Paul Eggert
2021-08-25 10:57       ` Lars Ingebrigtsen [this message]
2021-08-25 17:59         ` Paul Eggert
2021-08-26 13:52           ` Lars Ingebrigtsen
2021-08-26  3:57         ` Richard Stallman
2021-08-26 13:54           ` Lars Ingebrigtsen
2021-08-26 14:07             ` Andreas Schwab
2021-08-26 16:52               ` Paul Eggert
2021-08-27  3:30               ` Richard Stallman
2021-08-25  8:37     ` Michalis V.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r6hn64r.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=11912@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=mvar.40k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).