From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50179: [UPDATED PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Date: Sun, 19 Sep 2021 16:45:48 +0200 Message-ID: <871r5kpqsj.fsf@gnus.org> References: <838s0rvyfu.fsf@gnu.org> <83zgt6vi43.fsf@gnu.org> <87a6l5k9xr.fsf@gnus.org> <87lf4p3210.fsf@gnus.org> <831r6hv51r.fsf@gnu.org> <87h7fc2vd4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27657"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50179@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 19 16:47:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRy64-00071A-Ra for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 16:47:12 +0200 Original-Received: from localhost ([::1]:43464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRy63-0006yp-Lx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 10:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRy5u-0006yS-HT for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 10:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRy5u-0001p7-9C for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 10:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRy5t-0003t3-R1 for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 10:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 14:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50179-submit@debbugs.gnu.org id=B50179.163206276414875 (code B ref 50179); Sun, 19 Sep 2021 14:47:01 +0000 Original-Received: (at 50179) by debbugs.gnu.org; 19 Sep 2021 14:46:04 +0000 Original-Received: from localhost ([127.0.0.1]:39497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRy4x-0003rl-Rd for submit@debbugs.gnu.org; Sun, 19 Sep 2021 10:46:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRy4t-0003r4-ED for 50179@debbugs.gnu.org; Sun, 19 Sep 2021 10:46:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vjeYVf6DbEcW0OWVysWgUF/o0l8s7+Ml6mW7ONN7L2g=; b=SWbaiaW4des9InPMMJpFGfrjgd 2s5/V/hBhmned3YfhHt98s4oJcqErPag+WKbXWTMEIATLtI8AlYuXr/jR8iDPR8qjs0i1bH/S8uix px3gDl0SCFyXUjj/jwSi/6E6vPYHhAjwBDbQ41E2UDESpu+laLgT0rf1hqTP0y2hA5mY=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRy4k-0007zG-AH; Sun, 19 Sep 2021 16:45:52 +0200 In-Reply-To: (Jim Porter's message of "Sat, 18 Sep 2021 11:58:12 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214717 Archived-At: Jim Porter writes: > There's one further enhancement that might make sense here: currently, > color values are set via a vector of strings for `ansi-color', whereas > they're set via faces for `term-mode'. Would it be better to use faces > for `ansi-color' too? Perhaps they should even be the *same* faces; is > there any reason an Emacs user (or package) would want ANSI colors to > be different between `ansi-color' and `term-mode'? If so, maybe each > `term-color-FOO' face should inherit from the (hypothetical) > corresponding `ansi-color-FOO' face? It seems like term.el was reworked in commit ae4969c2d69a74c896eb49c9a34aeb645ffed082 Author: Julien Danjou AuthorDate: Thu Jun 28 12:40:24 2012 +0200 to use faces instead of colour names, but ansi-color wasn't. Looking at the code in both ansi-color and term, I think it would indeed make sense to rework ansi-color to use faces, too, and inheriting like you suggest makes sense to me. (We generally prefer using faces instead of colour names these days.) But: > However, maybe there's a particular reason why `ansi-color' works this > way that I'm not aware of. If the current way is best, that's fine by > me too. Otherwise, just let me know and I can update the patches to > include `ansi-color-FOO' faces. I'm not really very familiar with ansi-color.el. Does anybody else have an opinion here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no