Eli Zaretskii <eliz@gnu.org> writes:

> No, I think it's wrong to set the face GC in xdisp.c, because the GC
> is fundamentally terminal-specific, so it belongs to xterm/w32term
> etc.  I'm not even sure xdisp.c knows the exact type of GC, which
> differs according to the platform.  The logic of selecting the face
> should indeed be removed from x_set_mouse_face_gc, but the calls to
> XChangeGC etc. should remain there.

Thanks.  Here's a patch that should remove the issues you pointed out: