From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51653: [PATCH] Fix dumping stretch glyph when drawing s->next in NS port Date: Sun, 07 Nov 2021 16:00:52 +0800 Message-ID: <871r3swg23.fsf@yahoo.com> References: <871r3swg23.fsf.ref@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26538"; mail-complaints-to="usenet@ciao.gmane.io" To: 51653@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 07 09:02:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjd7z-0006iO-K9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 09:02:11 +0100 Original-Received: from localhost ([::1]:39296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjd7y-0006Kd-Ab for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 03:02:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjd7q-0006KH-Je for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 03:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40148) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjd7q-0001fL-Au for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 03:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjd7q-0007Tb-6P for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 03:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 08:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51653 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163627207628678 (code B ref -1); Sun, 07 Nov 2021 08:02:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Nov 2021 08:01:16 +0000 Original-Received: from localhost ([127.0.0.1]:51693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjd75-0007SU-Rn for submit@debbugs.gnu.org; Sun, 07 Nov 2021 03:01:16 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:40950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjd72-0007SL-GM for submit@debbugs.gnu.org; Sun, 07 Nov 2021 03:01:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjd72-0006IW-8e for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 03:01:12 -0500 Original-Received: from sonic316-22.consmr.mail.ne1.yahoo.com ([66.163.187.148]:37857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjd6z-0000NA-Ga for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 03:01:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636272065; bh=grt0qgv302DSaelLAohSGHoZpg0aXLUIM5znyD+1rpw=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=hrt7v6nah5d0Q7/jbA9PuNOroIyZyrL8BYQ6QJMGm396wetSHQ0iAnc1dGhWWcIkin1oRvAbLNxaZrdPg589UbHyj83D1GAjE0cYj7+wQV2JOy2i+dFYHKzd2Bpp3t76wNBHNmvgR2Zka0cwKccJ5s1jvmaTWcYdJ7fS8QiAeBLbQgq6jSVG4zlugDC0E3Vzm71V+HK9kcI0Qh/x4Ha8X2p8hubE79ftZP8WZGmti6I04x4/bUyhL61zI8L0PFMN+vHraRh94F26WlnJjOlSkCQrfIoGptsERGHJWlt5nNmAcfFLE2qedZEAAxsuiVIvoU3kf51LXqQDNlKqeXgk2A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636272065; bh=/2oatekd3xJHFY/q96VwbD14Z7XdlIGIc22iClZ2aMR=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=CcrqvrsXwT/LspmVXmHeSScBMIyLDW3WIWYd427HBL2EIOpddX7MUVnCbn3P4DIumlX6tDgp74/KcKC9FThA3mdnYr3Wsam6Z4cCFSpzaXFMhBkLKleNX7m+o5LayZxGCpWdFVPKHlTngQIFjbomnFJi6Omp5PW5lK8RQy8PcYN0sC48wTPndOJgROJHccLmFa2mq2MMZmKi6QJjGuSDME/6HU93CXlCANi9+U3p9hQUDK7Ox5HMgIQVRqmQuZKDHdUfK0ba+wd/JJoeKPe1xZoqvs3aVbbg1q6vSMS3fMyuWmo4IRq5ucQtiw1Y4kqRHQVSWiIqtTrvI9/0khSXvQ== X-YMail-OSG: RbeTW9sVM1nISLi9qeihpip0dfYGiVBOxiUngCJ39FM4ZlL2fKHghgpJruBgH6V xgzPezBu3slvGwBSizWsQW_npGDFnO8AEBMrevgP8zfXMyYzMbltA2XstaogDrW8oxddN.MhRzLf ISPgv3DMR1._5XR6qGOubDUZP9w3kV7FOrqIGZ02p58NlganOkCozk.nxCzT4P4p.KcWokfd5xeW GptY6m0b6zlIlyML3l.JPjhxJojpHjOWUCsUFdfsOqJIwzmcPBOZCjqjdWmRmgR8dnZW_tGTeMQJ YUrfgX.6atW7Vp6C5JqFXYdyQvPmOSXR0vgH8IdfzjAsuaY7Z3b8ps26_qjz3WZA3jiA14_Q53ka FmWZhhVodaxcCFD90Iove3MGvzJxjbEbHZ37QrSC8tTm0yWrmwKtTwu_8oS.4z5lBW8U2wPR8CAh 8edWO_sFd.H344JCqzwruweliM6lmxiayrCg8nkOqxMuIcwdu8wDXWJSRaNYL06dFeZtUhX2FKQf Bg7EwKgc5KptNqHZM4ePF_IYQ.1dJVUR8RqMwxZoU30BvAgwbEGdEQ9PJTk16KJS.Ssky_ix1XHw VuqkifPm2gTJ8Ys.KICF80BxVP6YFSBOIEa8Fp0nFmabB.q50bpNiobn4Zm_.q3OCgboXJMV5mhx aqn_NIKZpokSFYHJ1ZU5kmnxPKGQIkG7OeTkq1EtfXPGjDz3qtprpJ0Z0nZPGb.kCv4yevBG1hWE wxuhNwk1empAGo56eAaF.aUZonZaWK1f.szDl.tudgm_n1nv_lyyCrXNcuT10VaAreikR_b15tVl iO_5K_825sK.G8TiqqJPlQlUFhUlFtTQ9pQvFUWp_E X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 7 Nov 2021 08:01:05 +0000 Original-Received: by kubenode502.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 2a9446abf753c4acfae53662091736d4; Sun, 07 Nov 2021 08:00:58 +0000 (UTC) X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.148; envelope-from=luangruo@yahoo.com; helo=sonic316-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219213 Archived-At: --=-=-= Content-Type: text/plain Otherwise, scrolling in a document with stretch glyphs can cause them to overwrite parts of the mode line, in some cases. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Set-clipping-when-dumping-stretch-glyphs-in-some-cas.patch >From 6a2449af61a6be75bd4d0945b8009320745b5ff2 Mon Sep 17 00:00:00 2001 From: Po Lu Date: Sun, 7 Nov 2021 15:58:11 +0800 Subject: [PATCH] Set clipping when dumping stretch glyphs in some cases * src/nsterm.m (ns_draw_glyph_string): Always focus even when dumping stretch glyphs in s->next. --- src/nsterm.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index a63883cd08..4e84e130b8 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -3991,17 +3991,17 @@ Function modeled after x_draw_glyph_string_box (). width += next->width, next = next->next) if (next->first_glyph->type != IMAGE_GLYPH) { + n = ns_get_glyph_string_clip_rect (s->next, r); + ns_focus (s->f, r, n); if (next->first_glyph->type != STRETCH_GLYPH) { - n = ns_get_glyph_string_clip_rect (s->next, r); - ns_focus (s->f, r, n); ns_maybe_dumpglyphs_background (s->next, 1); - ns_unfocus (s->f); } else { ns_dumpglyphs_stretch (s->next); } + ns_unfocus (s->f); next->num_clips = 0; } } -- 2.31.1 --=-=-= Content-Type: text/plain Thanks. --=-=-=--