From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Sun, 26 Dec 2021 21:32:17 +0100 Message-ID: <871r1zm7ji.fsf@gmail.com> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8805"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51809@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 26 21:33:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1aCd-00029J-Kt for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 21:33:11 +0100 Original-Received: from localhost ([::1]:43314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1aCc-0002CL-LT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 15:33:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aCT-0002Bv-VV for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 15:33:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1aCT-0000Ts-ML for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 15:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1aCT-00080U-KH for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 15:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Dec 2021 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164055074630728 (code B ref 51809); Sun, 26 Dec 2021 20:33:01 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 26 Dec 2021 20:32:26 +0000 Original-Received: from localhost ([127.0.0.1]:41636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBu-0007zY-FX for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:32:26 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:52808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aBs-0007zI-Mv for 51809@debbugs.gnu.org; Sun, 26 Dec 2021 15:32:25 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id g132so8601453wmg.2 for <51809@debbugs.gnu.org>; Sun, 26 Dec 2021 12:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ENI60ZEOrnZ79lbOnhvmmDZpTo9n7kRjQUDQaZRDZuY=; b=BbFQU59/rA42LcLQ/P73o96JmgoDkZP9ozWoZVXxa0yD4BwJE5IEQxGiOtPnpizg5S TM83Je+xSZCGuSIUKqaBYkebiA+hARylPRwH3KJdyrP3bV5BFqvrlLcG+NIhHZ2vXqpX 59d1ob3GSIjJ8W6k1ZAhfvHrGLOCPCufWFCKTvT3f2ZvPorgu+jCF8dLr7K+N5Hiy9Fr yR4x1Y90t33o9zXDBn84CVucy5syb2Dm1bBNqDOLQ3SgzAUnZx3YPd5PdTOEE6T6GFqR jDrV6vLaQMNuFHY8yBGpjg3/cLOIVFpWqJcMg83yyCeP56Kjp9Az/4qseMHgt4m6ATP8 ySaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ENI60ZEOrnZ79lbOnhvmmDZpTo9n7kRjQUDQaZRDZuY=; b=RuAQjqXl02hx/B0uovLwfBwHrE6JDrgcfFKWZXU5hu19MCi4dDkerI2IGHXewVet8G v55gb/DhERQctg+vZsApttS08Xpmi5xB3FuGOKgk5rUxzPZ3QK1leniuLWtdenI51ZLp y3oqTA3dKC6mQZ4Bf719ILtdfbeWs9//eveuWVY7tMHBqbqZmYqT4+qsk2WGJr2tvm75 ioGnuzsq1CS4cSz0Oi1hki1Kk6lUSoJzLkMF3ipiSXdpTRLbfwKNuN/Kw3RKnPUHEuxk 4lUjJVWGbil8tXLyWsHHdcA6v3aK9eUN1AFH2JdkLQC7c2SftZ9aVwVXzN+BpOj8N3nz yfZw== X-Gm-Message-State: AOAM530DfOprDnDG2//uRR01VqTWDASQOSrwm+o41IFKBQ4HakAjfUgh MVvRLbnFI1QJDwwKM2kPx5+TvRpvt4g= X-Google-Smtp-Source: ABdhPJxlNJiyUPMB7ApFhou7S91tpEPtPkGj10PuCEOsNCMZIu798ra8uThUHP+mYoig2xcj9e5j/A== X-Received: by 2002:a05:600c:4f08:: with SMTP id l8mr11294375wmq.59.1640550738441; Sun, 26 Dec 2021 12:32:18 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id b10sm13731371wrg.19.2021.12.26.12.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 12:32:18 -0800 (PST) In-Reply-To: <87r19zs662.fsf@gmail.com> (Matthias Meulien's message of "Sun, 26 Dec 2021 17:05:25 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223165 Archived-At: Matthias Meulien writes: > There's a bug when used with diff-mode (where `outline-level' returns > unexpected values), the starting point of that thread! I'll try to > study this in the forthcoming days. Fixed with (applied to the patch sent in reply to Eli's suggestions on documentation): diff --git a/lisp/outline.el b/lisp/outline.el index ad45e38946..2dc9805b85 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -1449,7 +1449,7 @@ outline--show-headings-up-to-level ;; Then unhide the top level headers. (outline-map-region (lambda () - (let ((current-level (outline-level))) + (let ((current-level (funcall outline-level))) (when (< current-level level) (outline-show-heading) (outline-show-entry)) I am now back to the origin of this bug report (toggling visibility of some diff hunks depending on long lines, chunks size, or file names) and I see there's a major drawback with the outline mode default visibility state approach: When outline minor mode is set through diff-mode-hook, the buffer is emtpy and applying the default state visibility is a no-op; It's a side-effect of the buffer content being generated asynchronously...