From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning Date: Thu, 13 Jan 2022 10:11:33 +0100 Message-ID: <871r1c6lve.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2477"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53153@debbugs.gnu.org, Stefan Monnier To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 10:12:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7w9Y-0000Ow-0U for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 10:12:16 +0100 Original-Received: from localhost ([::1]:32956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7w9W-0005ym-HI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 04:12:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7w9R-0005yW-Iq for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 04:12:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7w9K-0005IO-AF for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 04:12:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7w9K-00014h-2Y for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 04:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53153 X-GNU-PR-Package: emacs Original-Received: via spool by 53153-submit@debbugs.gnu.org id=B53153.16420651044101 (code B ref 53153); Thu, 13 Jan 2022 09:12:02 +0000 Original-Received: (at 53153) by debbugs.gnu.org; 13 Jan 2022 09:11:44 +0000 Original-Received: from localhost ([127.0.0.1]:60172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7w92-000145-Dv for submit@debbugs.gnu.org; Thu, 13 Jan 2022 04:11:44 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:52114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7w90-00013o-V3 for 53153@debbugs.gnu.org; Thu, 13 Jan 2022 04:11:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tqVVLjjUXO5X+5GhIo44pO3MGp1nCFkjdMiRNbBpw6E=; b=CTJ6KlsNgHR3bkj2H4li6jymJe qhC8GRc9pTMW+0xm3yDlUlbXKI09291Qm4UEavCocsWCI0B31L69hPSlIkEyEOu9k2Fe/4gs4M5WE l9L2sDIOqcf6J1M+G/zesncNbtXiuCGzs9oxIDqVTA3tnHPF9hjJg5cFFsmIIXIfTee4=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7w8r-0000rJ-S2; Thu, 13 Jan 2022 10:11:36 +0100 X-Now-Playing: Panoptique Electrical's _Decades (2001-2021)_: "Never Sleep Again" In-Reply-To: (Stefan Kangas's message of "Sun, 9 Jan 2022 22:46:59 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224083 Archived-At: Stefan Kangas writes: > This unusual arrangement means that we end up with this interesting form > in package-quickstart.el (pretty-printed): > > (define-minor-mode selectrum-mode > "Minor mode to use Selectrum for `completing-read'." > :global t [...] > 1. Does it make sense for Emacs to be complaining about a defcustom > here? AFAICT, there is no defcustom in the above form. Do we care, > or is this use case just unsupported? define-minor-mode expands to (among many other things) a defcustom form, I think? > 2. I guess the other question is why `selectrum-mode' is not just in its > own file, if startup speed is of the essence. Maybe Stefan Monnier > has something to add here. Yeah, it seems like a pretty weird thing to do. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no