From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 53153@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning
Date: Thu, 13 Jan 2022 10:11:33 +0100 [thread overview]
Message-ID: <871r1c6lve.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkm=FBeSJdNb9tj+Cnj8_4K+bjHJPBkx1fntTgCvF-d2e-g@mail.gmail.com> (Stefan Kangas's message of "Sun, 9 Jan 2022 22:46:59 -0600")
Stefan Kangas <stefan@marxist.se> writes:
> This unusual arrangement means that we end up with this interesting form
> in package-quickstart.el (pretty-printed):
>
> (define-minor-mode selectrum-mode
> "Minor mode to use Selectrum for `completing-read'."
> :global t
[...]
> 1. Does it make sense for Emacs to be complaining about a defcustom
> here? AFAICT, there is no defcustom in the above form. Do we care,
> or is this use case just unsupported?
define-minor-mode expands to (among many other things) a defcustom form,
I think?
> 2. I guess the other question is why `selectrum-mode' is not just in its
> own file, if startup speed is of the essence. Maybe Stefan Monnier
> has something to add here.
Yeah, it seems like a pretty weird thing to do.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-01-13 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 4:46 bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning Stefan Kangas
2022-01-13 9:11 ` Lars Ingebrigtsen [this message]
2022-01-13 11:20 ` Stefan Kangas
2022-01-13 14:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-13 15:30 ` Stefan Kangas
2022-01-13 16:20 ` bug#53153: [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r1c6lve.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=53153@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).