From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell Date: Wed, 02 Feb 2022 19:10:22 +0100 Message-ID: <871r0lrvg1.fsf@gnus.org> References: <75056e6b-c739-a48c-2bf8-56ddc456da8e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19231"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53715@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 02 20:32:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFLMg-0004lu-Q4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Feb 2022 20:32:26 +0100 Original-Received: from localhost ([::1]:42868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFLMf-0006e5-Pi for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Feb 2022 14:32:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFK5v-0006Zn-UO for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 13:11:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFK5u-00073a-4Z for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 13:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nFK5t-0000O3-VW for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Feb 2022 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53715 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53715-submit@debbugs.gnu.org id=B53715.16438254351448 (code B ref 53715); Wed, 02 Feb 2022 18:11:01 +0000 Original-Received: (at 53715) by debbugs.gnu.org; 2 Feb 2022 18:10:35 +0000 Original-Received: from localhost ([127.0.0.1]:53453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFK5T-0000NI-5z for submit@debbugs.gnu.org; Wed, 02 Feb 2022 13:10:35 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:42344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFK5R-0000N1-Jf for 53715@debbugs.gnu.org; Wed, 02 Feb 2022 13:10:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yrc9IaEVBhqj+vAZEs+O7DYOUoEbaihLNQjzLp2jLGc=; b=dvGzmBplJ1qnqOcXEFXj2GPUbQ FvThbkWSNhdmxsRWychroJsKRTkSo0VPSSq2cFsdvd84LTN0Q1R4yYDjRfpe70jxVD9J29MYu+2dn X8wkfV+eGWtiOh7DwEaYUF7n1/eedNVTCD3RvQjEjm8gFiqNUVhGBJR95aEJqnbTCVpU=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFK5I-0006aQ-VL; Wed, 02 Feb 2022 19:10:27 +0100 X-Now-Playing: The Residents's _Intruders_: "Frank's Lament" In-Reply-To: <75056e6b-c739-a48c-2bf8-56ddc456da8e@gmail.com> (Jim Porter's message of "Tue, 1 Feb 2022 19:32:10 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225814 Archived-At: Jim Porter writes: > This happens because Eshell only keeps track of the tail process when > running an external process, so when sending stdin, it gets sent to > the tail process (`rev'), not the head (`tr'). I fixed this in the > second patch by recording both the head and tail processes and > updating the various places that use the current process to use the > right one. These patches seem to lead to a number of tests failing: Test eshell-test/last-result-var2 condition: (void-variable eshell-last-async-proc) FAILED 22/34 eshell-test/last-result-var2 (0.001074 sec) at lisp/eshell/eshell-tests.el:164 passed 23/34 eshell-test/lisp-command (0.000350 sec) passed 24/34 eshell-test/lisp-command-args (0.000308 sec) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no