From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54698: non-recursive GC marking [PATCH] Date: Tue, 05 Apr 2022 09:15:09 +0800 Message-ID: <871qyc5o0y.fsf@yahoo.com> References: <5A577100-75CE-4C9E-A7DA-02B917662AF5@acm.org> <8735itglid.fsf@gnus.org> <8527E407-8190-4574-B8D5-BE68220AE663@acm.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36602"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Lars Ingebrigtsen , 54698@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 05 03:16:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbXo0-0009KE-7p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Apr 2022 03:16:24 +0200 Original-Received: from localhost ([::1]:34924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbXny-00010j-Md for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Apr 2022 21:16:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbXne-0000wy-06 for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 21:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59514) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbXnd-0002fB-NX for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 21:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbXnd-0003eV-Jg for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 21:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2022 01:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54698-submit@debbugs.gnu.org id=B54698.164912132913990 (code B ref 54698); Tue, 05 Apr 2022 01:16:01 +0000 Original-Received: (at 54698) by debbugs.gnu.org; 5 Apr 2022 01:15:29 +0000 Original-Received: from localhost ([127.0.0.1]:53411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbXn7-0003da-Gl for submit@debbugs.gnu.org; Mon, 04 Apr 2022 21:15:29 -0400 Original-Received: from sonic308-10.consmr.mail.ne1.yahoo.com ([66.163.187.33]:45642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbXn5-0003dE-BZ for 54698@debbugs.gnu.org; Mon, 04 Apr 2022 21:15:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649121321; bh=MwnyjKmJOGWhtslaDDY+q2SmPGL6HIAcgSuuu4dJNqo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=PmcMzhQrTmdaJ0qFfgiXhzEesbHq3DQXhHiUsnLhq0hsrqzr9wUq3Jyc4K5GNoBOPz3P+YYS9vtjUSDTqg1u4EiqAyb+LOjIZmormMFwszakXe42MiWROLJeEEAwjI3uvt21nRKOI/Ezegu5Ux/ypEoZTv1oO20Z4xEAr5yzE6waj0A+iV5eCcUX2U3EEYwHDpN/3z1gKu6jyAMTaGB5iRgZuEE28cknQoQBr4H1cYWNSoP4tlIqd3o10j9E/JL3Xgau0uRzvlJr6NIY65ZuFCjoFIXyW5Knf+5y6FKMqwzkyWHqpnIp6ummotcYx/OuNSfhuoDBNzjR6WrsBX5a6Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1649121321; bh=Ji0I2DtmI/HRD2nuVcoOeZi6Mg6f0c/sItzubnrNZGv=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Z4dKOSoqLwzW0Gj7R2mXa0Kppwb9EciTYzHLxEp4BFc/E526Law/zMWg8A0+RfV1r8cS/Y5MvuBQhEPm4eG5hF9xbPEIlAIMKGmg9cydpF6srmQ6LAPVl8+n+SVJbU/VoCbu9vXW3z9M3wRc2BqFkUTAH4K37I5eTKkz1Hd+sqFMn0v1LijkFKXwAZweSFDkasluGAWnsWLU0pjOb2KDMmM9uBqIakVPulQtI+BMMKyqw4Uew2mknNYiGR4uPakwNsUdX4YUO08AB9iAIzQbo2K+nfRXqx214C+4/HDKDeMvLD0Q1tHh1rotT6QeJjdF7AHtK/dJT9cFkXWofoTvtQ== X-YMail-OSG: vpPcRR0VM1njQdrQHMwzEB1ilzo4uwD1ajpu.xjPiwwBBPaa93HQC_uCgKECDPF varq7CW7QCM_Sqe_cIuCneywrgncG4MJpeOjUFn7btps1e64uIIXje73tfMqSo7rx9.OY68BPFMY LXGXyfd0okZjA7nRiwhn2ZihO11pGHZD8StNpGjGO8VS2VyQGV6TFMZRNNp5OxDrX.YH33D1oVy2 eIp314Clbd0Q71wrzHML5Mtg8IClmldvMiU2ZOBwmkdYPi87jvmWP4BCi.QlHFehlLv7AOuz67x_ yHQNSg7lL4.xEiR_CjTZxhUDYLAi9kVr0GQfSwPAkD2pCY9lg8_GUA2OxTUFkDeYqZFEbk8hyET6 1rUvpXgA0VFQaOqtadlGQX3Osfe4JAbCG_yrD967j_kavCcqTbsDlCZ6_LjiQ4ucgLA2X_RA9yLr .kJNuJY18ZnkOUg7M.61IAnED9fhp6O_Yysow.phIGxKr.tRhEQoFWMWP6QpgdjWR_iypOccXKGK F1.i1UcAYN14ilY1bs3RMDgfM89lOzj05F4WONH6tABQu3i4aNZsaxkg6fzPxJ2bfKIE3SBJs21C rWRiFRHv4Te43k2fUtSvrrHOok5wjtQRAeE_LTirC5yTyEBLcGE9YlNHoapHnooVebAvQg7Id.a8 Olo2LLpa8ffo5AZHihBXX41Mbxlfe0YbqLTZE.4D5ZikFV5hXLSnEIjx8gXuFmyZmBqlL4Lcq4vK doTvI1I3NsghAN98s0a0yhu58YvgGHx1NpGogxYBdVBK.5gsdBMNfIlSS7ZwwfC5bKRciX7ukM28 YCJqa4lbIGn6JepJHxtDfZEmRp0loB3ocsEM9OXNUm X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Tue, 5 Apr 2022 01:15:21 +0000 Original-Received: by hermes--canary-production-sg3-65d7bd97b5-gqv44 (VZM Hermes SMTP Server) with ESMTPA ID 8380ecf653bf650f4c798acb9b159d39; Tue, 05 Apr 2022 01:15:15 +0000 (UTC) In-Reply-To: <8527E407-8190-4574-B8D5-BE68220AE663@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 4 Apr 2022 13:16:26 +0200") X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229427 Archived-At: Mattias Engdeg=C3=A5rd writes: > No, the mark stack grows as needed. I see no reason to limit the size > since it's going to be much smaller than the size of the heap being > traced in any case. What happens if it runs out of memory? The incremental GC I'm working on also has a similar stack for objects that have not been marked yet, and it also grows dynamically. If growing the stack fails, it aborts garbage collection and tells the user to type C-x s and exit Emacs. Objects are left with mark bits, but that is the case when Lisp code is allowed to run "between" parts of garbage collection anyway, and I hopefully did a good enough job fixing the code that assumed objects cannot have mark bits during regular Lisp execution.