From: Tassilo Horn <thorn@fastmail.fm>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juri Linkov <juri@linkov.net>,
No Wayman <iarchivedmywholelife@gmail.com>,
55149-done@debbugs.gnu.org
Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor
Date: Thu, 28 Apr 2022 16:39:11 +0200 [thread overview]
Message-ID: <871qxh6zf8.fsf@fastmail.fm> (raw)
In-Reply-To: <jwvsfpxgu6e.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> It is, thanks. Shouldn't you also adapt the add-function docstring?
>> Oh, that's adapted automatically! Interesting approach.
>
> :-)
> Actually, it was done to avoid copy&paste between the docstrings of
> `add-function` and `advice-add`, but it's nice that it also avoids
> duplication between the code and the doc and makes sure the doc is in
> sync with the code.
Indeed, and I think until recently advice-add didn't document HOW but
just referred to add-function which was a bit annoying because usually
one uses advice-add so does C-h f on that and then needs to TAB to
add-function to get the docs on that.
Would you mind adding this magic also to define-advice so that the HOW
is described there as well?
Bye,
Tassilo
next prev parent reply other threads:[~2022-04-28 14:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 5:15 bug#55161: 29.0.50; [PATCH] oclosure transcription error redux dick
2022-04-28 10:23 ` bug#55149: " Lars Ingebrigtsen
2022-04-27 12:48 ` bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Tassilo Horn
2022-04-27 19:41 ` No Wayman
2022-04-27 21:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 3:39 ` Tassilo Horn
2022-04-28 4:02 ` No Wayman
2022-04-28 6:58 ` Juri Linkov
2022-04-28 7:12 ` Tassilo Horn
2022-04-28 7:22 ` Juri Linkov
2022-04-28 7:31 ` Tassilo Horn
2022-04-28 13:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 14:14 ` Tassilo Horn
2022-04-28 14:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 14:39 ` Tassilo Horn [this message]
2022-04-28 2:06 ` bug#55149: (No Subject) M. Ian Graham
2022-04-28 4:06 ` bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor M. Ian Graham
2022-04-28 4:47 ` Tassilo Horn
2022-04-28 6:12 ` M. Ian Graham
2022-04-28 6:28 ` Tassilo Horn
2022-04-28 6:56 ` M. Ian Graham
2022-04-28 13:50 ` bug#55149: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux Rudolf Schlatte
2022-04-28 13:28 ` dick
2022-04-28 13:42 ` bug#55149: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 15:26 ` bug#55161: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Jonas Bernoulli
2022-04-28 16:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-28 22:49 ` Jonas Bernoulli
2022-04-28 23:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qxh6zf8.fsf@fastmail.fm \
--to=thorn@fastmail.fm \
--cc=55149-done@debbugs.gnu.org \
--cc=iarchivedmywholelife@gmail.com \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).