unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Mattias Engdegård" <mattiase@acm.org>, 55676@debbugs.gnu.org
Subject: bug#55676: [PATCH] non-recursive Lisp reader
Date: Sun, 29 May 2022 09:15:11 +0800	[thread overview]
Message-ID: <871qwddtr4.fsf@yahoo.com> (raw)
In-Reply-To: <83v8trm0b1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 27 May 2022 19:01:54 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks.  One minor nit: you seem to have customized indentation in C
> source files in a way that is different from our conventions.  Please
> reformat using our defaults (which use a mix of TABs and SPACEs).

Another minor nit:

>> +	    read_stack_push ((struct read_stack_entry){
>> +		.type = RE_record,
>> +		.u.vector.elems = Qnil,
>> +		.u.vector.old_locate_syms = locate_syms,
>> +	      });
>> +	    locate_syms = false;
>> +	    goto read_obj;

There should at least be a space between the cast and the opening brace
of the compound literal, right?  That applies to the rest of the printer
code you installed lately.

And I think using compound literals in `read_stack_push' (and
`print_stack_push') is very ugly, but there's no rule against it.

Thanks.





  parent reply	other threads:[~2022-05-29  1:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 13:33 bug#55676: [PATCH] non-recursive Lisp reader Mattias Engdegård
2022-05-27 14:03 ` Lars Ingebrigtsen
2022-05-27 16:01 ` Eli Zaretskii
2022-05-27 16:49   ` Mattias Engdegård
2022-05-27 17:26     ` Eli Zaretskii
2022-05-29  8:27       ` Mattias Engdegård
2022-05-29  1:15   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-29  8:45     ` Mattias Engdegård
2022-05-29  9:09       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-29 10:33         ` Mattias Engdegård
2022-05-30 15:21           ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qwddtr4.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=55676@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).