From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54863: 28.1; hook move-frame-functions not working in emacs 28.1 Date: Tue, 06 Sep 2022 21:35:29 +0800 Message-ID: <871qsobp7i.fsf@yahoo.com> References: <0ee6195e-4561-d9ff-e30b-68707ce14b9e@gmx.at> <87r162wweb.fsf@yahoo.com> <877d2gu4u0.fsf@gnus.org> <87a67cbt0t.fsf@yahoo.com> <877d2gskjd.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24544"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: James Ahlborn , martin rudalics , 54863@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 16:15:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVZM0-0005xW-1d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 16:15:04 +0200 Original-Received: from localhost ([::1]:45996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVZLz-0000xL-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 10:15:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVYkF-0003t5-Hb for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 09:36:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVYkE-0001Rw-L5 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 09:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVYkE-0000RT-Gw for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 09:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54863 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54863-submit@debbugs.gnu.org id=B54863.16624713521680 (code B ref 54863); Tue, 06 Sep 2022 13:36:02 +0000 Original-Received: (at 54863) by debbugs.gnu.org; 6 Sep 2022 13:35:52 +0000 Original-Received: from localhost ([127.0.0.1]:50170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVYk3-0000R2-UE for submit@debbugs.gnu.org; Tue, 06 Sep 2022 09:35:52 -0400 Original-Received: from sonic315-20.consmr.mail.ne1.yahoo.com ([66.163.190.146]:40988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVYk1-0000Qf-KF for 54863@debbugs.gnu.org; Tue, 06 Sep 2022 09:35:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1662471343; bh=ihVfi/631jUKKWlIYGdau2I/L9osi01rGo7lg7XILpM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Q9QC+BcNaGZay93dI3R6zKnf+KfPz6TfyEvDDdCr9bjwUAKDhtn8rjMPNM/Ms226Mdtie7sEIkUlXxJba3Fc61p4VdsVuSbu8oWdplAkZ4/IvXqKH8yIv/in5MElxfDisUnbiI67FkziUKd7Do15btPdUJC2yAyqEsusnfvbP7wErTIUjLfURC/3QMWkNAEGtHIdnxQ7sYIWUBWoUIIcErZK5pWMvLBrMWtzKlzR4q7KETcZb8m5aHe1qHnKKbiUJu2mWuROd/KQT6tZtuNjaJPRmtS+2rjiE2z+Hn4cU8IxgIRIF8wfVFKVt1YUFQCBkJYapjpzV0HqTfURWaU2GA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1662471343; bh=MGYcuWDFvREgOww2QU+B+YY3mzB1BxmrZq3sroIXxrc=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=LnRW1rnFPVMb9ll0OD9NrNiUIYNTdJA5dAkeZPREX+cuplVK4kWUPUeDOqvIJIh3P3DVbnLJPfC0XsiXu2AyIizdV16Rh3NfvRc6A4fRZuopnfPzUkShimY6Ab4H7Gshkmq48NlliMa76aoBv3s2HCUnXOzPP4OM5HZaU78UOBXdy4Jg7fHVOuVJbYSCPoANg7dC9urGPwE1SR0ifdCUxjrPve8peH2FmNFb0pm4qJFxD8zc2uqs3Q3XYHJSgmNxRWFuw+gDZu8ZtW0HXePPIFJUWhuUS4ThaiIQdHNbDPeOYwlztKYrMCMkk+TLvWcturNB7O0auHg8Fa4gPuegzg== X-YMail-OSG: Wk0xe1QVM1kHqIS0WJJtZzdpOFK2SIPLm6QFbRJkriWMeikW0D1zvh0jODmZK8B z700dG1p3mHt9UiInkYP7.YZ3GilbCqiwWDqOvU0GXlMEE67KyBu41Tb28ubWNSmZoFHpVM6Z3do vwGCXiv4F8cxdHZbq2kA6NnX2PaInTIpfPRvLs1iReZgEsf2pQE_RW14AIrET4FaW.5aJuYgqrr. CHHs7y.uskEVOWRY2L_u2n_5GPvHTFURbOydrwl9yMKelmOJqicqggx_PYzSH2Sf.jnvwtOnU4qV 6b2l8HDH7vnrAA.YHA1N8zgyXLCH.EZJD1wpYdPKIJnRdBDzrkKxPA1nXRbvAbLm4cVKbjgL218y IOT6k6ZSa4bruhF1kkamxlNPFMO6m3PEGv5DmdA9FaJYsnVLsuApk_2dX4_52VBXoIqLDUQ8XS55 1sdUFXF9pNuOVxXKhcNdktS.oXxof8h7THz6MzbsDDDnYjiNYdnvgB_Ml4WRkZgU_q1jrtR0Bapq PmTkCde.G0hNxbhymM.divmF7PiigwuYDTVQqPs9UsiNbGi4L70RAOoYtnd9jvhGHeAt3xRMAoju P6Ej5C5BsS3Q6_.HuSQ4.3HNL92qpeMe.JzFDzARJt0GYDGW1EnPCpnhjVUjhx4avqQS27z2Vtue TkoCCBRafrK0sbRjaH9m0nmUjbvRNyFqRB.uNLCbiPEE3CFwBuaDnYJD3po2GfRhKOye4R59bM_e tVndFhZkkLaEyxH4uv0xYMdbzO1LprVCXCY0bSY_UjhEiZSY6uImpYA33.cDIcNG89oGYwsOF7Se cdF0PND_I0JzLs6vfLePhOWV6Okjeta27DuzaW3Pc_ X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Tue, 6 Sep 2022 13:35:43 +0000 Original-Received: by hermes--canary-production-sg3-6bb8946c47-n8gf6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 88168a22ce70a5fc7be262945250ab52; Tue, 06 Sep 2022 13:35:37 +0000 (UTC) In-Reply-To: <877d2gskjd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 06 Sep 2022 15:24:22 +0200") X-Mailer: WebService/1.1.20595 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241665 Archived-At: Lars Ingebrigtsen writes: > With the following patch, the hook fires when I move the frame on Macos. Nice! Are the values of the parameters `left' and `top' correct too once the hook fires? Converting between the cartesian NS screen coordinate system and the X one is sometimes tricky, and I don't completely understand the NS_PARENT_WINDOW_XXX_POS macros. Thanks. > diff --git a/src/nsterm.m b/src/nsterm.m > index 6c6151701b..bc4e072ea0 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -7912,6 +7912,7 @@ - (void)windowDidMove: sender > NSRect r = [win frame]; > NSArray *screens = [NSScreen screens]; > NSScreen *screen = [screens objectAtIndex: 0]; > + struct input_event ie; > > NSTRACE ("[EmacsView windowDidMove:]"); > > @@ -7922,12 +7923,14 @@ - (void)windowDidMove: sender > emacsframe->left_pos = NSMinX (r) - NS_PARENT_WINDOW_LEFT_POS (emacsframe); > emacsframe->top_pos = NS_PARENT_WINDOW_TOP_POS (emacsframe) - NSMaxY (r); > > - // FIXME: after event part below didExitFullScreen is not received > - // if (emacs_event) > - // { > - // emacs_event->kind = MOVE_FRAME_EVENT; > - // EV_TRAILER ((id)nil); > - // } > + if (emacs_event) > + { > + ie.kind = MOVE_FRAME_EVENT; > + XSETFRAME (ie.frame_or_window, emacsframe); > + XSETINT (ie.x, emacsframe->left_pos); > + XSETINT (ie.y, emacsframe->top_pos); > + kbd_buffer_store_event (&ie); > + } > } > } >