From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Mon, 12 Sep 2022 12:10:19 +0200 Message-ID: <871qsgc390.fsf@gnus.org> References: <875yhzmz25.fsf@posteo.net> <875yhzmj50.fsf@gnus.org> <875yhzl3a1.fsf@posteo.net> <87fsh25bso.fsf@gnus.org> <871qsil3jm.fsf@posteo.net> <87fsgygo7c.fsf@gnus.org> <87a676jfx2.fsf@posteo.net> <87bkrmdt46.fsf@gnus.org> <8735cxpx2r.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="370"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu , 57639@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 12 12:13:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXgRM-000AU7-Ua for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 12:13:20 +0200 Original-Received: from localhost ([::1]:35248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXgRL-00035T-S0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 06:13:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXgP8-0000hu-4C for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 06:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXgP7-00059L-PL for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 06:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXgP7-0004lG-Ks for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 06:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2022 10:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166297743618265 (code B ref 57639); Mon, 12 Sep 2022 10:11:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 12 Sep 2022 10:10:36 +0000 Original-Received: from localhost ([127.0.0.1]:44151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgOi-0004kW-AK for submit@debbugs.gnu.org; Mon, 12 Sep 2022 06:10:36 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgOg-0004kJ-Sq for 57639@debbugs.gnu.org; Mon, 12 Sep 2022 06:10:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8Xc/vXO90cOHRbCNZSf4Lc5skEaUHqESPKMoiAvWTNo=; b=q4dJAeuIywH4yw1kYW8XtSu7oN bD/nqN9LSVyYZMeMDhkEOu3MKPjhbCyQguGxVs8MxTatWxmyUd07cwjjqKhupuREQBO0Hqd/PA9Jx oMjtnAYUOXWNuGvcU7mdVx/FS+thucieDn4ZZnRbUufafjo0ivjd0qkgwsWYRDxCJM7I=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXgOT-00057U-Qu; Mon, 12 Sep 2022 12:10:28 +0200 In-Reply-To: <8735cxpx2r.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 11 Sep 2022 18:47:40 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUoKi0JBgdNVVvA ys91gor////Gs4NHAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJDAk7Foy47hAAAAGfSURBVDjLlZPt lYQgDEUDTgHBsQBAG1iTAhig/5o2BMePmfXHokfRa/KSB4JBC+CMO42Zs3HQ5xewBLmAuxl3AMG6 IBQdGs0oE31eYJUnMJuM6XpyG8D8KYAO/J043gHzH/AIqH3s9ewgWdMiUM8dNVU02nlE3zxA/NQA 6FJfQJJ+1IAAmnD6ajN2d/G7aNh86+PE4XhRndszek2FXRrOACA04I/W9lSrfqAFXnwDCh049Jf1 ByJvIDWQ4ykCBRBHBZQ/wVpfMrWFLxpLXl2RCJsHldtBlIIHphow0iUih4d5UqFso79aEsYwUqXV grh/8QrmhSvxsmLJFxAXX6U2StNWsDaqPsDAlYNBWtUC2NbDvuzUWjDIqzSP0C66S0SycElm5Gpl 69tqDuMG6T88OVtAX0tooHv9FMfCzMnCIxZ1YPsNRqnKlOoh8kzcfqz3GhSiUDj6mdsnbgyw7Zwm QpJKzCERH1Nf2p5LcmhAqypBOnLRz8SF3hHHwkgE6WCb7BkU2gbDGbj9PbFvILx39VK3XDWHFD3s IVaBHB38AvdFaWXTEet7AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA5LTEyVDA5OjU5OjIyKzAw OjAwI+RHuwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0xMlQwOTo1OToyMiswMDowMFK5/wcA AAAASUVORK5CYII= X-Now-Playing: David Lynch's _Ghost of Love_: "Imaginary Girl" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242224 Archived-At: Philip Kaludercic writes: >> I thought we already had support for this under Gtk? But I may be >> misremembering. > > Am I reading it correctly that `style_changed_cb' in gtkutils.c would be > a place to start looking for this functionality? Ah, yes, I think that's the one... Po Lu probably know more about this; added to the CCs. > So would gruvbox-soft-dark have all the other themes as variants or only > gruvbox-soft-dark?=20=20 Well, I was saying that the term "variants" isn't really what we need here, but tagging themes for features. So gruvbox-soft-dark would say (theme-featues :name 'gruvbox :mode 'dark :softness 'soft) or... feature names that make more sense. =F0=9F=98=80 Then the `theme-change-feature' if you have a gruvbox theme enabled would give you three other themes to choose from. If there's just the dark/light difference, then there's only one other theme to choose from, and no prompting would be needed.