From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Date: Sat, 17 Sep 2022 13:31:55 +0200 Message-ID: <871qsack44.fsf@gmail.com> References: <87illme7fe.fsf@gmail.com> <83sfkq1gu0.fsf@gnu.org> <87a66yclqr.fsf@gmail.com> <83mtay1c38.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21163"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: public@protesilaos.com, 57876@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 17 13:33:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZW4c-0005Fn-Ft for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 13:33:26 +0200 Original-Received: from localhost ([::1]:57320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZW4a-00041G-Un for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 07:33:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZW4G-000404-5Z for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 07:33:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZW4E-0007oB-F7 for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 07:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZW4E-0008QS-2b for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 07:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 11:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57876 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57876-submit@debbugs.gnu.org id=B57876.166341432632297 (code B ref 57876); Sat, 17 Sep 2022 11:33:02 +0000 Original-Received: (at 57876) by debbugs.gnu.org; 17 Sep 2022 11:32:06 +0000 Original-Received: from localhost ([127.0.0.1]:45272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZW3K-0008Oq-2O for submit@debbugs.gnu.org; Sat, 17 Sep 2022 07:32:06 -0400 Original-Received: from mail-ed1-f53.google.com ([209.85.208.53]:34407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZW3G-0008OH-Qn for 57876@debbugs.gnu.org; Sat, 17 Sep 2022 07:32:04 -0400 Original-Received: by mail-ed1-f53.google.com with SMTP id z21so34964826edi.1 for <57876@debbugs.gnu.org>; Sat, 17 Sep 2022 04:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=1XNOaQc9lYfCL8xy4ui++nme2V9rKyrTquJXxsn8bMM=; b=dy/93yqo4Hv4Ts9WZaGxljdJ/BFoS+9aT8xtXt5ayELpnKDN7kTqoC+djjDHVWM96G Mqr6nMP3AFGRnCA9nugNkYnuVLkLmb7FDIGTqRvQsdHPxaNJ9uFNkQQ0AeYVuoU4o/40 +3Gtw+1u1ZziYBzmR1yKFIHUfH4H92/wgBN7jq4TOWzmmbHeF4FmAc8u9p9Gq9OjEBcj q8OfqOxv4Z7+Hhmftsl5x7zk7qW27DvEf7yEuB6JtjgD5LhG4CZV0F7JDJ3aAxErwzWu 7hWstxmAR/TROg3fz+fARIpBzIVaO2h1swElQ0a1J3m3YrxM5EESDgZ8+lfsfjwGfskC n8KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=1XNOaQc9lYfCL8xy4ui++nme2V9rKyrTquJXxsn8bMM=; b=QOXipsZbRcJlIumX+20m73ZSgavJuN2njWzey73Vn0n0eKvsXTkdtGvJJ6RqiCtV5L sS0yOVaUX+EwbAntx6kcrDpsrJK75JGE7BC8emND8jmx93DVFO4jBTjJek+CHbiAbNRh bAOUCa9kEOb1BS8ZHSG1WEkZX9x4NJUlE7vltHP4BzwScEI5COO6rP5XSH6RxQZIg8Qm vp72pkW0sG0ReDq0OJ4VZfRNlL/PqfvWHcEni/KTwKEBP6dDGFzna9Mqb4ld9zoJPa4n mHu5TNowJQjag8/UcGX1e0vlpDDmZGmOQTH20kIa+x2uEbRLm6U4eXqKrucvmWYfddyr oCpw== X-Gm-Message-State: ACrzQf0m9+0vgZgtgykjLzuBzQZQrjxqpwMTGEVHDFFI7YOik/5fIyMd 2OkG+kd+dwQ1WvRZDi3nE8E= X-Google-Smtp-Source: AMsMyM6KPSISFUtLg13vQZ8mZgGD2KMv/ZSyulrc4g7U71Hd9PivsfSXXGmDE3prVssMsPZaFmvp5A== X-Received: by 2002:a05:6402:410:b0:451:ea13:4ed7 with SMTP id q16-20020a056402041000b00451ea134ed7mr7950576edv.262.1663414316998; Sat, 17 Sep 2022 04:31:56 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id u3-20020a05640207c300b00451e3160451sm11533644edy.89.2022.09.17.04.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 04:31:56 -0700 (PDT) In-Reply-To: <83mtay1c38.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Sep 2022 14:20:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242863 Archived-At: On Sat, 17 Sep 2022 at 14:20, Eli Zaretskii wrote: >> From: Augusto Stoffel >> Cc: 57876@debbugs.gnu.org, public@protesilaos.com >> Date: Sat, 17 Sep 2022 12:56:44 +0200 >> >> > Why don't you use beginning/end-of-visual-line? >> >> Because it obeys fields, so if you try to highlight a prompt line in a >> comint buffer, only part of the line would be highlighted. > > It should be possible to disable fields temporarily by binding > inhibit-point-motion-hooks, right? I prefer doing that to reinventing > the wheel of moving to the edges of the visible line. This variable is allegedly obsolete since Emacs 25. In any case, the patch is really trivial, so how would this be making the code simpler or more robust?