unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Augusto Stoffel <arstoffel@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: public@protesilaos.com, 57876@debbugs.gnu.org
Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
Date: Sat, 17 Sep 2022 13:31:55 +0200	[thread overview]
Message-ID: <871qsack44.fsf@gmail.com> (raw)
In-Reply-To: <83mtay1c38.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Sep 2022 14:20:43 +0300")

On Sat, 17 Sep 2022 at 14:20, Eli Zaretskii wrote:

>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Cc: 57876@debbugs.gnu.org,  public@protesilaos.com
>> Date: Sat, 17 Sep 2022 12:56:44 +0200
>> 
>> > Why don't you use beginning/end-of-visual-line?
>> 
>> Because it obeys fields, so if you try to highlight a prompt line in a
>> comint buffer, only part of the line would be highlighted.
>
> It should be possible to disable fields temporarily by binding
> inhibit-point-motion-hooks, right?  I prefer doing that to reinventing
> the wheel of moving to the edges of the visible line.

This variable is allegedly obsolete since Emacs 25.  In any case, the
patch is really trivial, so how would this be making the code simpler or
more robust?





  reply	other threads:[~2022-09-17 11:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17  8:23 bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Augusto Stoffel
2022-09-17  9:38 ` Eli Zaretskii
2022-09-17 10:56   ` Augusto Stoffel
2022-09-17 11:20     ` Eli Zaretskii
2022-09-17 11:31       ` Augusto Stoffel [this message]
2022-09-17 11:49         ` Eli Zaretskii
2022-09-18  7:23 ` Protesilaos Stavrou
2022-09-18 11:02 ` Lars Ingebrigtsen
2022-09-18 12:40   ` Eli Zaretskii
2022-09-18 12:45     ` Lars Ingebrigtsen
2022-09-18 12:55       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qsack44.fsf@gmail.com \
    --to=arstoffel@gmail.com \
    --cc=57876@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=public@protesilaos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).