From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Tue, 20 Sep 2022 21:08:29 +0000 Message-ID: <871qs5lpo2.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <871qsil3jm.fsf@posteo.net> <87fsgygo7c.fsf@gnus.org> <87a676jfx2.fsf@posteo.net> <87bkrmdt46.fsf@gnus.org> <8735cxpx2r.fsf@posteo.net> <87k066yyn0.fsf@posteo.net> <877d269kgv.fsf@gnus.org> <87bkriyqci.fsf@posteo.net> <874jxa6kyj.fsf@gnus.org> <87o7vdg97w.fsf@posteo.net> <831qs926np.fsf@gnu.org> <871qs9fzz5.fsf@posteo.net> <83h715yxz2.fsf@gnu.org> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21655"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 57639@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 02:31:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oane4-0005VM-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 02:31:20 +0200 Original-Received: from localhost ([::1]:35742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oane3-0002zk-Fz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Sep 2022 20:31:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oakUI-0000Hw-Mi for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2022 17:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oakUI-0001ME-Cl for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2022 17:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oakUH-0002Yp-SS for bug-gnu-emacs@gnu.org; Tue, 20 Sep 2022 17:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Sep 2022 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.16637081269822 (code B ref 57639); Tue, 20 Sep 2022 21:09:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 20 Sep 2022 21:08:46 +0000 Original-Received: from localhost ([127.0.0.1]:59860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oakU1-0002YM-K9 for submit@debbugs.gnu.org; Tue, 20 Sep 2022 17:08:45 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:43875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oakTw-0002Y4-CF for 57639@debbugs.gnu.org; Tue, 20 Sep 2022 17:08:44 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D8351240026 for <57639@debbugs.gnu.org>; Tue, 20 Sep 2022 23:08:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1663708114; bh=J4DE/dQocp4QjtgPOBHim3bAHQktRbOGXz1LZ5d+0PQ=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Uh6dMsgyW0xZ5T+qRSuumqKeamKlYwBC/B0MVHNASXdftjAO4yZWu4coRwAZHbmgP 27U1pACWfcwT0yzm1RMH2xrM3B3GvFx7Ws1YKIBspFOY4Hos5/0hC/TOe2bjQX+ETQ VKqzIAqEokdEplBERjKLRNV4p27nhVH/VWrfV8T148qUce8nWXD3gwDPWkL9kMtb8a VqUplvelCY9DVytNTyHjy5sjG16kxUx6mS2xkCvjhKz/mtrnSMuOQjAD/vE8ldyPWJ 6JxaKA0VS2I4J8/9MVXr3Sp+qTtQ8uh6Ca511J0feAH37Qm75g+mKdUyHUyv9I1KYA k98mnFToxmQyQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MXDfl3FPhz9rxP; Tue, 20 Sep 2022 23:08:30 +0200 (CEST) In-Reply-To: <87bkrbfz8l.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 19 Sep 2022 12:13:46 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243255 Archived-At: Philip Kaludercic writes: > Lars Ingebrigtsen writes: > >> Philip Kaludercic writes: >> >>> I don't think so, but if a theme were concerned about this, all they >>> need to do is >>> >>> (put 'theme-name 'theme-properties '(:background-mode light :kind color-scheme)) >>> >>> As that is all the macro does. >> >> Ah, then that's fine -- feel free to push when you're ready. >> >>> As I said, we could do this too and add >>> a autoload-cookie before it to solve the visibility issue, but it >>> doesn't look that nice... Can (deftheme)s be autoloaded? >> >> Hm... well, anything can be put into the loaddefs.el file, really, so >> yes, but I'm not sure we want to... > > I think I'll modify the patch for now and pull out the properties via > `put' calls, and maybe someone will think of a better solution later on. I've just tried this out but it appears that despite re-building Emacs the autoloaded calls are not registered. Is this because of some special handling of themes?