From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Wed, 21 Sep 2022 13:38:13 +0200 Message-ID: <871qs57yai.fsf@gnus.org> References: <875yhzmz25.fsf@posteo.net> <87k066yyn0.fsf@posteo.net> <877d269kgv.fsf@gnus.org> <87bkriyqci.fsf@posteo.net> <874jxa6kyj.fsf@gnus.org> <87o7vdg97w.fsf@posteo.net> <831qs926np.fsf@gnu.org> <871qs9fzz5.fsf@posteo.net> <83h715yxz2.fsf@gnu.org> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1653"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 57639@debbugs.gnu.org, Protesilaos Stavrou To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 13:40:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oay5A-0000IP-EU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 13:40:00 +0200 Original-Received: from localhost ([::1]:52482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oay57-0007gH-LS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 07:39:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oay4F-0007dc-7k for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oay4E-0000Cq-Lx for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oay4E-0000MO-DT for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.16637603071342 (code B ref 57639); Wed, 21 Sep 2022 11:39:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 21 Sep 2022 11:38:27 +0000 Original-Received: from localhost ([127.0.0.1]:60919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oay3e-0000La-Qg for submit@debbugs.gnu.org; Wed, 21 Sep 2022 07:38:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oay3d-0000LK-3A for 57639@debbugs.gnu.org; Wed, 21 Sep 2022 07:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uT8Pbi6m3gRUu3CfXErhpVSPw0dhTfp6P5Wkvc5WMVU=; b=R/y7QgA341yaqJAaS/uWOxyrSK 91fLXLcuf2A+aJ/+IUBGKShTZBK3FA9jl9pb7bIIHcKsHV+f8n9zd4oZvyJ3d1YC/VQFzNP8rI7RO 4ywwSyKasHhuz0s8wAoYoYXSYFWi22jv6yidKcA98M1Q6pkYkwf8lhXxXKbALzyx3pRY=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oay3T-0004UO-CN; Wed, 21 Sep 2022 13:38:17 +0200 In-Reply-To: <87bkr9newj.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 21 Sep 2022 11:30:20 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUFAwQtGxNVPRu8 oC67QBj///9p7MsAAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJFQsUGrmHVi0AAAG0SURBVDjLdZSN lYMwCIAhtwBJHcBEFzhxgGtk/5kOSFqj16PvtZUvhH8BYheKBB8ES4mx6NedBuacmGuED+DBPAN8 tNiQ8HZZA093lq9APReCDMl+BmB6Paq608RubSAaSKm0GII+N5AkyYxFb+u55Q5WOfYtbDO0yDB1 wLscIjNvr2ropwElIs8gtYc1O1g6qYTNhbryq7igSCNnCmSZF1jFpfaqBKJWEpAulcaSbHmSg9nJ FdAj/wMWKR7wDRQ6Kk3qYJUy9DFshZb6rUCs83gFO6+H5BxTvlmoZ96m74zP0UcGHYb92FG7MVro gHyxym4R/QG7Akt7voJgFix5iAkwMAG+QOy1TbkUtLYtDnp6WJK12/0V7Ycm0gFqzwnBnmLU+so5 o+6L/I+SE5SM7/CiFqsQYh+r8AKICjLkh9cE+wkfsSRV7RYNXvVwJqQGs8c9+yC+Nk+PTF4mX60Q c8IGeuNScmBXpaZZm0/e3svYnKD1j3DVuhzjUkVKYtNbdYjqoLc1mZRInJh/RqCZoU11TusxdArA Wjf5TK8y6sHmD3Xg63Q8LyB5JPqqSZdFvwn+Aim9Vvm0oiCCAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIyLTA5LTIxVDExOjIwOjI2KzAwOjAwv9uAjAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0y MVQxMToyMDoyNiswMDowMM6GODAAAAAASUVORK5CYII= X-Now-Playing: Niki Mono's _Contradictions are a Luxury_: "Baby's On Fire (Instrumental)" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243305 Archived-At: Philip Kaludercic writes: > Ok, that sounds good. Here is the updated patch: [...] > This is actually done a few times by the modus themes and at least once > by `leuven-dark' (see `leuven-dark-scale-font', tough I don't see why, > and if the autoloads aren't being generated to begin with the cookie is > pointless anyway). > > Should this be addressed before the patch is pushed? Hm... are these themes also distributed via ELPA or something? But in any case, I don't see why you'd have: ;;;###autoload (defun leuven-dark-scale-font (control default-height) If you've activated the theme, you've loaded the file, so autoloading a function like that doesn't seem helpful in any case. So I think that sounds like it's just a mistake, and the ;;;###autoload should be removed. And the same with the commands autoloaded in modus themes? But perhaps there's a reason; I've added Prot to the CCs. Perhaps he can clarify why those autoloads are in modus*.el. But this looks more problematic: ;;;###autoload (when (and (boundp 'custom-theme-load-path) load-file-name) ;; Add theme folder to `custom-theme-load-path' when installing over MELPA. (add-to-list 'custom-theme-load-path (file-name-as-directory (file-name-directory load-file-name)))) We don't want that in the Emacs loaddefs file, so just adding etc/themes to our Makefile won't be the right thing to do, and we have to find a different way to fix this. Uhm... Uhm... I don't immediately see a good way to fix this...