From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#57556: 28.1; Eshell not finding executables in PATH when tramp-integration loaded Date: Sat, 01 Oct 2022 22:25:52 +0200 Message-ID: <871qrrffzj.fsf@gmx.de> References: <87h715j5gy.fsf@gmx.de> <0480c49e-75da-68c4-d255-242ff65323fe@gmail.com> <87czbsjyby.fsf@gmx.de> <877d1vthto.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: coltonlewis@google.com, 57556@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 01 22:27:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oej4q-0000oq-Vn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 22:27:13 +0200 Original-Received: from localhost ([::1]:58174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oej4p-0001No-UO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 16:27:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oej4i-0001NR-5H for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 16:27:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oej4g-0005fA-Ot for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 16:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oej4g-0001Hj-A9 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 16:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2022 20:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57556 X-GNU-PR-Package: emacs Original-Received: via spool by 57556-submit@debbugs.gnu.org id=B57556.16646559654875 (code B ref 57556); Sat, 01 Oct 2022 20:27:02 +0000 Original-Received: (at 57556) by debbugs.gnu.org; 1 Oct 2022 20:26:05 +0000 Original-Received: from localhost ([127.0.0.1]:45750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oej3k-0001GZ-LT for submit@debbugs.gnu.org; Sat, 01 Oct 2022 16:26:04 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:33063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oej3g-0001Fz-Pe for 57556@debbugs.gnu.org; Sat, 01 Oct 2022 16:26:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664655953; bh=iYhHKUUzRG1DiR1JKL3uJ5U90c55HgcNnUL/LNRY9KU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=lA5HPqYEwDBbXqZcXC05ESWWAQRYppJnHfUzXQ2GauSVmV3WsNvmjlBXDVrbQGVLB EBy97lZeOxTGXqR6x7qbSlU2ZI0rbtasREsRlGQU/P1qo8OUa6GzFVrxr4ABoESTqt mw2v+lHALp6q1IYYwAR4VbU/4T1RksgDJWcbr/uc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.148.109]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mv2xU-1pVSCX1Qky-00r39p; Sat, 01 Oct 2022 22:25:53 +0200 In-Reply-To: (Jim Porter's message of "Thu, 29 Sep 2022 20:54:43 -0700") X-Provags-ID: V03:K1:WVYgsZ41pm5BeUqa1+JxYOP1ZQMTT5sq6LB1un/d7dJ0rYzgRbv +hOcZMjypeM6ZijjaVEkNEltyhhNroFERUNZ0Wmtk9oZG3YaDzDhTLR/EW5EQGMpiX2+rbA EyBNg/10CZp7oyOGA+PCFfqdpFAFcyPCvUmorsOre6tBmh4Q5pxAR9GbFJoYpZYQgZOZqWu eJQhim7Vr073bha+2pj8A== X-UI-Out-Filterresults: notjunk:1;V03:K0:SVhc9Z1CQFI=:iESXp1jUIYiPqHH9WGyXsO YhYWJhK27l1sNcDoOy0XzAcKDM2/Yn0TfkVx7/zRXLIBfTmEaMyM+TEnZvlTycfo2VGz3u09u tKXkuyFutbjkfx/P7Foy7x3fQcpKiPHts/tYuPB+/oIPTzj3MfEM/ouW9XfNEJBfyQ0eVhUx0 4GT0rL2mHFGA/5tpuHBEOAiqz6CaiStpmKBWQI+wKbTsLAbBOvwq3s0P7URE97pi/psjjcIHb b95dpxKjXC/wsdxfygPPjGnGC0XPNa6EIPdpXX4e0f4AtOnVXqIeLlkpSWeYFiszqYe4HLbA0 huExUN8nv9lgjY4p+k5G7TaOkFFh/QRj7SSTNeL7QFXZrTCeKA8gLCa95FAwXs1gidNE+DfQ/ LAhaoEWMRQzDtz4ZOVG5kuyG73BTXUpOpnZrQk0aNBG6DdHbQqsoxQ4WNWWCNUaI0fB2XW5in IxFp2Xyhlvv0jBAO8J636qrtMCE0l7oznhSKA9zEUllL6dc/a4fAgA/2vQPU6dS1ZZPrEdwtD q+pxO4j5Fl+ggJystEIxknDeWgIYVwp6KHvSZXG+gXxFznrfnvU+eBaV29tr2qYuc3G4WPfAt b4K+U18v2nTLhGqRuXOz9DA3hLjoiETe9YMYmWCftF8tjRalKBmbU0zS31+jwuiION52A7Wkf DuMJxCtu2o4HOr8R3fAlGJwX+0tsBfzh2heie5DISAl0cGQvXWpY5994sjiFqSF+NC6yyA3LE Uxck2HQzLIugJdG3pTZRtLalJxDSjm2uIMCwz13UTvO3SPgqbV3yNMO3EEnVdY5f+pUCOGgA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244164 Archived-At: Jim Porter writes: Hi Jim, I didn't install your patches, but I gave them a cursory review. > Patch #3: Allow setting variable aliases > ---------------------------------------- > > Since the plan is to make $PATH into a variable alias so that Eshell > can do the right thing when changing directories to a different host, > I wanted to be sure users can *set* variable aliases so that updating > $PATH will be easy. This adds the ability to do that, along with a new > "set" command in Eshell. That lets you set either environment > variables or Lisp variables (note that "#'" is just Eshell's way of > spelling "'", since a single-quote is used for literal strings in > Eshell): > > set ENV_VAR value > set #'lisp-var value Well, in Elisp the #'symbol read syntax is used for function names, see (info "(elisp) Special Read Syntax") So it is surprising to see it used for variable names. > Patch #4: Make $PATH a variable alias > ---------------------------------------- > > This stores the $PATH in an alist indexed by host, similar to > 'grep-host-defaults-alist'. For consistency, it now derives its value > from '(exec-path)' everywhere (formerly, it used '(getenv "PATH") for > local hosts and '(exec-path)' for Tramp). Again, no possibility to use connection-local variables? You use them already by calling (path-separator) ... Personally I believe 'grep-host-defaults-alist' shall also be changed to a connection-local mechanism, but likely, this would break too much code in the wild. > -(defun eshell-get-path () > +(make-obsolete-variable 'eshell-path-env 'eshell-get-path "29.1") I guess you mean 'eshell-host-path-env' as CURRENT-NAME. > +(defun eshell-get-path (&optional local-part) > + (let* ((remote (file-remote-p default-directory)) > + (path (cdr (eshell-get-path-assq remote t)))) > + (when (and (eshell-under-windows-p) > + (not remote)) > + (push "." path)) > + (if (and remote (not local-part)) > + (mapcar (lambda (x) (concat remote x)) path) Why not file-name-concat? Otherwise, I'd say let's install the patch, and see how it goes. There isn't too much time left until the feature freeze in November. Best regards, Michael.