From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#58256: Possible mistake in recent `dired-do-flagged-delete' change Date: Sun, 02 Oct 2022 22:46:15 +0200 Message-ID: <871qrqt0mg.fsf@gmx.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27018"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58256@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 02 22:47:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1of5rx-0006tR-Pn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Oct 2022 22:47:25 +0200 Original-Received: from localhost ([::1]:41028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1of5rw-0000Yv-Ss for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Oct 2022 16:47:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of5ra-0000Ye-Hr for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 16:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1of5ra-00007D-8c for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 16:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1of5ra-0005gw-3m for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 16:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2022 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58256-submit@debbugs.gnu.org id=B58256.166474358621834 (code B ref 58256); Sun, 02 Oct 2022 20:47:02 +0000 Original-Received: (at 58256) by debbugs.gnu.org; 2 Oct 2022 20:46:26 +0000 Original-Received: from localhost ([127.0.0.1]:48184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of5r0-0005g6-4Z for submit@debbugs.gnu.org; Sun, 02 Oct 2022 16:46:26 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:43575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of5qy-0005ft-La for 58256@debbugs.gnu.org; Sun, 02 Oct 2022 16:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664743576; bh=ygpgsQcbAu1MiVDyTcbmRzhp2uU4XvbJRW56qvah8rk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=cbijzAbE5jG2NpJf8Hf0C3Llh+wgmb6m/5T2caWIsU6Sv/tp1q63s3QtOtxaC2/eW v2O7GZqgmsBC3kjvNszcqqNQvvRGBd2HoJgp5Zv93aaHplgjC31APokGJOFNu+WmnA JKhtAs0NCIgc29HXSgDmvM/+4qwVCFfC6xXQbwL0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs2 ([89.246.38.124]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgvvT-1p8MFx1K9d-00hLZl; Sun, 02 Oct 2022 22:46:16 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 2 Oct 2022 20:42:17 +0200") X-Provags-ID: V03:K1:LzlFufFMby0TGP7LkSe3y2doTdDUkxg1cdAX0uTDP0hoTT42hyR 4bstllWMdJdx4bK3CCWrRtZikJU0S0nvmOXAKg1Lu3kt9juk9xoA9nikG68HqKx4XTlLt02 hvT2tj6Cc4ceia2SzagwOYcDsD4l+A+tjm7tltFlYiCbxkv1LCEvAU0VuIpNHtb4fgZataX WwfC1ddHsu5ytRPGNvAvg== X-UI-Out-Filterresults: notjunk:1;V03:K0:K4otAOC7Vt4=:7t95eaSEAsFUCNfKiTaBhf uZxric0/uifR7OW1WEyQ0iSvpRBBXBaW//iSPjuchvJy3HMoQChx+Kb0ZIqhi2qTBN0No+WQ7 rRq67S1tLfvLSl+xTv75tNA8Hm1/5VTcTE+uO6J6MZZqnYiudsq5snOdf3EqEtMmS7peNcRLR LUoGbfQfLySSIXTxfgaizTXL4wLFa5yp7rnxibp25m5nF5u7FgEnzOZ9PkfqFXbPfEkI+dNR0 5iz8Itscp/HR/hMtUJwyzmjQY7kxEoYzA/dkzk259Vl/OpL30hdWK8D52BbhD1XsRdulkjbWh XCiWZ3+LIp3NJNesjUnWMmo7VDU0+nlFeUH4uNyQzCyTyFtG6ZO3jaW/ePbaagG+VANgPhL+F od0YW6ozUFlCgkecSHISPYBHPJimxrtbvzNX6ggXiIoek6OVR/K2NySu7y41ebxYsrL8v/jL5 s2LM6acjC4o5Y8fyYZc0a3gm6yWxadEDbvbADuya9gzM3VqiNhzzX+1fgbLzmScGIF8blZ4Se hm401zaOiwZJjgPyD19Pm6lp59DMdH5NA0fQNrj1nw8F7ljQmVllAnZo4CbbXK0JHyTRT2E8q qadGALimKhQQrIlU1S3lROrilq4TOIWDGkvAoCkhgvX/Ro7biNMmANFXm2dFn6bDf1m5tPlNr D1wWXS/wBYQIOKYIdroUQ3go5KpoWtTh2T6ENHqMHq4KMKQzVGJck7AisEvqRs+yE11nDA9TA aZFY2sLLA63Im2q6J5UQKbzAg/9s5HZ41UoxQyWGMmmyJxpyUSAANKGPBtbG7j2s2mXplMjb X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244261 Archived-At: On Sun, 2 Oct 2022 20:42:17 +0200 Stefan Kangas wrote: > It seems like there might be a mistake in the `dired-do-flagged-delete' > of this commit: > > commit 194d54a929a83fede75d618b104acd1b544feb10 > Author: Stephen Berman > Date: Fri Jun 4 12:01:41 2021 +0200 > > Fix placement of point in Dired deletion operations > > It seems like there is a `dolist' that will always run on the empty > list. Was perhaps the below the intended change? Yeah, it looks like I mistakenly put the dolist in the 'else' clause instead of the 'then' clause. Thanks for catching that. On Sun, 2 Oct 2022 19:17:27 +0000 Stefan Kangas wrote: > Stefan Kangas writes: > >> If so, I wonder how this code would have worked without that `dolist' so >> far, and if that line could just be removed instead? > > The command seems to be working correctly with the attached patch. > > Am I missing something here? I think doing it that way leaves the markers in the buffer, though probably for typical use cases that's not a problem, and it is simpler that way (as I noted when I posted my patch). I guess the same simplification can be applied to `dired-do-delete' as well. Steve Berman