From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Tue, 11 Oct 2022 19:51:48 +0000 Message-ID: <871qre2l63.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> <87y1udlzlt.fsf@posteo.net> <87o7v953uf.fsf@gnus.org> <87tu50nca7.fsf@posteo.net> <87a6652lyb.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> <87wn98nlhq.fsf@gnus.org> <87lepo9c1e.fsf@posteo.net> <87r0zfkxzx.fsf@gnus.org> <87pmeyg24x.fsf@posteo.net> <87edvef8nc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19966"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 57639@debbugs.gnu.org, Protesilaos Stavrou To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 11 21:52:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiLIV-00053N-2F for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Oct 2022 21:52:15 +0200 Original-Received: from localhost ([::1]:51092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiLIT-0001LJ-Md for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Oct 2022 15:52:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiLII-0001IU-Cd for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 15:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiLII-0001GR-41 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 15:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiLIH-0000vH-Tf for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 15:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2022 19:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.16655179203538 (code B ref 57639); Tue, 11 Oct 2022 19:52:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 11 Oct 2022 19:52:00 +0000 Original-Received: from localhost ([127.0.0.1]:54952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiLIF-0000uz-Mp for submit@debbugs.gnu.org; Tue, 11 Oct 2022 15:51:59 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:43991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiLIB-0000ul-RU for 57639@debbugs.gnu.org; Tue, 11 Oct 2022 15:51:57 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 11FA0240101 for <57639@debbugs.gnu.org>; Tue, 11 Oct 2022 21:51:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665517910; bh=286abr4hHyZ3pRL4Ed6psYxBO6RqmF6qz+8FHTS4zQE=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=P5VaFR9yuyG067RjtDL4gofkaT65tdHDPZaqtRHRrnF1lyJte8JycDV9+t9WMRZjs VSyhNbIxqjo6qkTXXR8FxeKzxmNdpP53w2AvxLrvKIGh5UYvOaDjdi9l2KOQOaiLV7 DWMmk5mSarQjPpmrwZzpiK3EPgbuB+xkxg0SPKH5iRDYzPn25orAEoYje7TBtaK64i W2Vm/blW+XzF2IO5ef1fNSpPgQuhXavElx7PUi18cP4ExCYGYG9Z2OHO7nzHiHIXsD QTzb1u97Hz9a4ngm5xidTZghfTf6mWBihmv151LMDrdlh5RthWKgMmxlpEo52F5dOP cH9zLxsWmHzdA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mn5yY1qbbz6tmF; Tue, 11 Oct 2022 21:51:49 +0200 (CEST) In-Reply-To: <87edvef8nc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 11 Oct 2022 21:43:51 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245143 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> The change to `deftheme' is only a feature of convenience, the >> backwards-compatibile way to set the attributes remains using `put'. In >> fact, that `put'-expression is exactly what `deftheme' expands to. > > But your patch added altered the deftheme calls (and thereby making the > themes non-backward-compatible) -- did you send the wrong patch? No, but these themes are built-in, and to my knowledge not distributed on ELPA (or at least changes in emacs.git are not exported to ELPA. The Modus Themes are manually synchronised), so it shouldn't make any difference. If so, I'll revert the changes where necessary.