From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Thu, 10 Nov 2022 08:47:32 -0500 Message-ID: <871qqavr3q.fsf@dfreeman.email> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> Reply-To: Danny Freeman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11078"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , dgutov@yandex.ru, felician.nemeth@gmail.com, 58790@debbugs.gnu.org, stefankangas@gmail.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 15:10:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot8G5-0002gt-Ed for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 15:10:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot8Fo-0002sS-Ra; Thu, 10 Nov 2022 09:10:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot8Fn-0002sC-M4 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 09:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot8Fn-0006RM-4b for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 09:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ot8Fm-0005eL-Vq for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 09:10:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Danny Freeman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 14:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166808936221651 (code B ref 58790); Thu, 10 Nov 2022 14:10:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 10 Nov 2022 14:09:22 +0000 Original-Received: from localhost ([127.0.0.1]:42336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot8F7-0005d8-UT for submit@debbugs.gnu.org; Thu, 10 Nov 2022 09:09:22 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:44019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot8F5-0005cy-Fs for 58790@debbugs.gnu.org; Thu, 10 Nov 2022 09:09:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1668089357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DZVbw5REhVrkVgEiwtKySLaPLkmgJTEK4O+sn9srATw=; b=uK5EeUapxoLJw4ArYUUH9Xy+hVHvruYLu2nb0W6Llprqc7WGPTOSucdJL7xEXiEilf7EGE SWiFghTlKe6kqUOFLM6yuDhCToZ0dQB3Dn4VWYHMvmnXdO1HIm/O1IqTh5RY2gbqn3M4xu I/94ghjNFKbCSmM8GbRZEuN+WN/Nw7k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87cz9v9irh.fsf@gmail.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247519 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Eli Zaretskii writes: > >> Ping! Jo=C3=A3o, any comments on this patch? > > Hi Eli, thanks for pinging. Yes, had a look and _both_ patches look > fine. > > The first patch touches a sensitive part. I hoped at this point to have > Eglot's automated test running in Emacs's repo, but I don't. So I trust > Danny has given some minimal testing to this, hopefully also with some > other server, for good measure. If it gives you some piece of mind, I've been running this code for a while in some large clojure, clojurescript, and typescript projects, all without issue.=20 I also ran through and did a quick test on a zig project (via zls) and in the emacs C source (via clangd) this morning. I've not noticed any issues there either, but also don't know much about either language.=20 > The second patch is a little riskier because it has the potential to > cause much warning noise, but I'd wait and see what it does in the wild. > If it does happen I think we have some means of toning down warnings > without making package's warning logic too complex. I will keep an eye out in this mailing list and try to help resolve any problems that might come up because of it. > So again, both patches should be pushed. I'm in the middle of a > bisection here, so if you can commit and push the patches, I'd be > thankful. Else, I will attend to that later. > > Jo=C3=A3o Thank you!! --=20 Danny Freeman