From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#59404: 29.0.50; Init-debug error when package-vc-install package and run older emacs Date: Sun, 20 Nov 2022 14:38:54 +0000 Message-ID: <871qpxn11d.fsf@posteo.net> References: <877czqtaki.fsf@163.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59404@debbugs.gnu.org To: Feng Shu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 15:40:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owlUd-0007EH-Uz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 15:40:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owlUJ-0003fQ-BR; Sun, 20 Nov 2022 09:40:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owlUI-0003fH-Bv for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 09:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owlUI-0003XQ-24 for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 09:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owlUH-0006Lw-To for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 09:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 14:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59404 X-GNU-PR-Package: emacs Original-Received: via spool by 59404-submit@debbugs.gnu.org id=B59404.166895514824351 (code B ref 59404); Sun, 20 Nov 2022 14:40:01 +0000 Original-Received: (at 59404) by debbugs.gnu.org; 20 Nov 2022 14:39:08 +0000 Original-Received: from localhost ([127.0.0.1]:42827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owlTQ-0006Kh-Bx for submit@debbugs.gnu.org; Sun, 20 Nov 2022 09:39:08 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:33975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owlTL-0006K6-5U for 59404@debbugs.gnu.org; Sun, 20 Nov 2022 09:39:07 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 35193240108 for <59404@debbugs.gnu.org>; Sun, 20 Nov 2022 15:38:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668955137; bh=Yg3HJ9yN4Sk1KkDRA3XEAA9WZlof5guapUotja6lY6A=; h=From:To:Cc:Subject:Date:From; b=azxH0hK/qp2OxEyd7b4zM91me/rQuuzt7lwYAky9Z2aXg9osnsNty99PBkin6Z/5N es+jO1hIhOmfgMakWuOD8lMcu7nmE/4YAXHe4qyBup2mDZgQptlEch9ENYthvAWqPM Ab8FmricmJmMUooccxsFQaFDBdhQTxwxJd+ptEWm26f4wo3x+xGloRoQnCM6jn+OBz wvKtPV4pBfElZQzcqyeQVpX6gNBLuGkeeMhJ6qkoArFSReJ/AQSx5JpiLcB231AmbD jngMIaPxMHmgGnMl2WAq052IDwucQp6HxsgRah1bereopYqPZDM84Bm4w4sjAoHGix 1hoxA+wLUuDWg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NFY742Vj0z9rxP; Sun, 20 Nov 2022 15:38:53 +0100 (CET) In-Reply-To: <877czqtaki.fsf@163.com> (Feng Shu's message of "Sun, 20 Nov 2022 14:16:29 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248426 Archived-At: --=-=-= Content-Type: text/plain Feng Shu writes: > When I package-vc-install corfu-terminal and run an older version > emacs Does the following fix the issue for you: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Don-t-break-when-loading-VC-packages-on-older-Emacs-.patch >From 94c6d2bffed33e78f10618b0e033a39071d6eb5f Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 20 Nov 2022 15:36:24 +0100 Subject: [PATCH] Don't break when loading VC packages on older Emacs versions * lisp/emacs-lisp/package-vc.el (package-vc--generate-description-file): Append a :kind property instead of modifying the version number. * lisp/emacs-lisp/package.el (package-desc): Remove special handling for "vc annotated" versions. (bug#59404) --- lisp/emacs-lisp/package-vc.el | 3 ++- lisp/emacs-lisp/package.el | 4 +--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 9e2bd106cb..c0079b8fe9 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -334,7 +334,7 @@ package-vc--generate-description-file (nconc (list 'define-package (symbol-name name) - (cons 'vc (package-vc--version pkg-desc)) + (package-vc--version pkg-desc) (package-desc-summary pkg-desc) (let ((requires (package-desc-reqs pkg-desc))) (list 'quote @@ -344,6 +344,7 @@ package-vc--generate-description-file (list (car elt) (package-version-join (cadr elt)))) requires)))) + (list :kind ''vc) (package--alist-to-plist-args (package-desc-extras pkg-desc)))) "\n") diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index c1545a2870..e11c5d693e 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -483,9 +483,7 @@ package-vc-p (if (eq 'quote (car requirements)) (nth 1 requirements) requirements))) - (kind (if (eq (car-safe version-string) 'vc) - 'vc - (plist-get rest-plist :kind))) + (kind (plist-get rest-plist :kind)) (archive (plist-get rest-plist :archive)) (extras (let (alist) (while rest-plist -- 2.35.1 --=-=-= Content-Type: text/plain Note that this requires re-installing the VC packages to make sure the -pkg.el files are regenerated. --=-=-=--