From: Philip Kaludercic <philipk@posteo.net>
To: Feng Shu <tumashu@163.com>
Cc: 59404@debbugs.gnu.org
Subject: bug#59404: 29.0.50; Init-debug error when package-vc-install package and run older emacs
Date: Sun, 20 Nov 2022 14:38:54 +0000 [thread overview]
Message-ID: <871qpxn11d.fsf@posteo.net> (raw)
In-Reply-To: <877czqtaki.fsf@163.com> (Feng Shu's message of "Sun, 20 Nov 2022 14:16:29 +0800")
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
Feng Shu <tumashu@163.com> writes:
> When I package-vc-install corfu-terminal and run an older version
> emacs
Does the following fix the issue for you:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-break-when-loading-VC-packages-on-older-Emacs-.patch --]
[-- Type: text/x-diff, Size: 2278 bytes --]
From 94c6d2bffed33e78f10618b0e033a39071d6eb5f Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Sun, 20 Nov 2022 15:36:24 +0100
Subject: [PATCH] Don't break when loading VC packages on older Emacs versions
* lisp/emacs-lisp/package-vc.el
(package-vc--generate-description-file): Append a :kind property
instead of modifying the version number.
* lisp/emacs-lisp/package.el (package-desc): Remove special handling
for "vc annotated" versions. (bug#59404)
---
lisp/emacs-lisp/package-vc.el | 3 ++-
lisp/emacs-lisp/package.el | 4 +---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index 9e2bd106cb..c0079b8fe9 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -334,7 +334,7 @@ package-vc--generate-description-file
(nconc
(list 'define-package
(symbol-name name)
- (cons 'vc (package-vc--version pkg-desc))
+ (package-vc--version pkg-desc)
(package-desc-summary pkg-desc)
(let ((requires (package-desc-reqs pkg-desc)))
(list 'quote
@@ -344,6 +344,7 @@ package-vc--generate-description-file
(list (car elt)
(package-version-join (cadr elt))))
requires))))
+ (list :kind ''vc)
(package--alist-to-plist-args
(package-desc-extras pkg-desc))))
"\n")
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index c1545a2870..e11c5d693e 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -483,9 +483,7 @@ package-vc-p
(if (eq 'quote (car requirements))
(nth 1 requirements)
requirements)))
- (kind (if (eq (car-safe version-string) 'vc)
- 'vc
- (plist-get rest-plist :kind)))
+ (kind (plist-get rest-plist :kind))
(archive (plist-get rest-plist :archive))
(extras (let (alist)
(while rest-plist
--
2.35.1
[-- Attachment #3: Type: text/plain, Size: 103 bytes --]
Note that this requires re-installing the VC packages to make sure the
-pkg.el files are regenerated.
next prev parent reply other threads:[~2022-11-20 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 6:16 bug#59404: 29.0.50; Init-debug error when package-vc-install package and run older emacs Feng Shu
2022-11-20 14:38 ` Philip Kaludercic [this message]
2022-11-22 0:24 ` Feng Shu
2022-11-22 21:33 ` Philip Kaludercic
2022-11-23 0:42 ` Feng Shu
2022-11-23 7:46 ` Philip Kaludercic
2022-11-23 12:25 ` Feng Shu
2022-11-23 18:32 ` Philip Kaludercic
2022-11-24 23:38 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qpxn11d.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=59404@debbugs.gnu.org \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).