From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#29108: 25.3; ERC SASL support Date: Tue, 29 Nov 2022 07:05:41 -0800 Message-ID: <871qpliywq.fsf__34861.2136136339$1669734406$gmane$org@neverwas.me> References: <87h8ud92zl.fsf@gmail.com> <874jx4h6sk.fsf@neverwas.me> <875yhifujk.fsf_-_@neverwas.me> <87edw4swdk.fsf@neverwas.me> <878rljxfxs.fsf@neverwas.me> <87k04m4th8.fsf@neverwas.me> <87o7thlepf.fsf@neverwas.me> <87o7taoohd.fsf@neverwas.me> <87a64unifk.fsf@neverwas.me> <87y1sdk1fg.fsf@neverwas.me> <875yfflzps.fsf@neverwas.me> <878rk9576b.fsf@neverwas.me> <87leo8z79j.fsf@neverwas.me> <87tu2vroeh.fsf@neverwas.me> <87wn7pog1l.fsf@neverwas.me> <87y1s4mjj6.fsf@neverwas.me> <87r0xvks03.fsf@neverwas.me> <87r0xtnk24.fsf@gnu.org> <87wn7jgkne.fsf@neverwas.me> <87iliyz6at.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36808"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 29108@debbugs.gnu.org, emacs-erc@gnu.org To: Amin Bandali Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 29 16:06:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p02Bx-0009K2-VH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Nov 2022 16:06:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p02BW-0007MY-Da; Tue, 29 Nov 2022 10:06:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p02BP-0007IZ-2U for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 10:06:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p02BO-0005d1-Q5 for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 10:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p02BN-0003Qb-LR for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 10:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29108 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29108-submit@debbugs.gnu.org id=B29108.166973436013171 (code B ref 29108); Tue, 29 Nov 2022 15:06:01 +0000 Original-Received: (at 29108) by debbugs.gnu.org; 29 Nov 2022 15:06:00 +0000 Original-Received: from localhost ([127.0.0.1]:54628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p02BL-0003QI-LB for submit@debbugs.gnu.org; Tue, 29 Nov 2022 10:06:00 -0500 Original-Received: from mail-108-mta87.mxroute.com ([136.175.108.87]:41147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p02BC-0003Q2-IP for 29108@debbugs.gnu.org; Tue, 29 Nov 2022 10:05:52 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta87.mxroute.com (ZoneMTA) with ESMTPSA id 184c3ec25590006e99.001 for <29108@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 29 Nov 2022 15:05:44 +0000 X-Zone-Loop: 455d215e6920d0ad2eed894df50b8c193dc4113b784e X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d+EiRL01RRisXNUJiL8Thqq9XI/1aHE9QHgctU25raY=; b=OqzWEHF6/mPnMRDBz1gEaxFz/F wVRazFHcqGhyuaoREnNyA/+iuVPhBaBL7a/TnStbBPzETiUng5X/Xbc/we9+GGLbfs0OnjEbVgZuG n5VRGzbRdg+wB1p3/WBWCUABtvIS9m/D3CevKtUFBLmKUs+rRCuTFTLJLpCbaTMvtJWG8pjdxkgdb CtOiQJbZtI+bio5kXWmGrZ9ReeA8ZFgIlCvkx3USZhFcWn9qkLA7EUQV8x+Gd0dtHn1+qDdkGRl5Z sY82kQDRvp+RflvA6re8MwdsTmHFjxqJKZ1ZAPbvefr5gfJ+XQkQ5Ma2KFYtl427L4JjkTRiJGh/J w6xKb6wQ==; In-Reply-To: <87iliyz6at.fsf@gnu.org> (Amin Bandali's message of "Tue, 29 Nov 2022 00:19:22 -0500") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249406 Archived-At: Amin Bandali writes: >> Right. Too cryptic. I've adjusted things in the second patch but am >> happy to redo/revise, as always. (The first patch contains a bug fix.) >> > [...] >> >> Good call. I've attempted something like that in a separate "examples" >> section (2nd patch). I'm hesitant about the last, "multi-network" >> example, though. It sort of implies we're committing to supporting >> let-binding as a means of specifying per-network local-module options, >> going forward, which maybe also puts us on the hook for (eventually) >> providing a mechanism to make options bookkeeping easier for would-be >> local-module authors. OTOH, neither of those is as yet a realistic >> problem. >> >> Speaking of maintenance burdens, I think `erc-sasl-password' is too >> overloaded and unwieldy, particularly WRT the "non-nil symbol" form. And >> falling back on `:id' is redundant because `erc-auth-source-search' >> already does that. So, as penance for my ugly API design, I've attached >> a (third) patch that tries to corral some of the crazy by adding an >> optional auth-source query function to house the more nuanced >> functionality (for those actually wanting it) while sparing everyone >> else the needless complexity. (That's the idea, anyway.) > > Thanks! Yeah, I don't really see supporting let-binds as too big of a > potential future burden. Worst case scenario, if/when local modules > are fully implemented and we and/or module authors find supporting > let-binding impractical, or there are clear advantages in not having > them, we could drop them in a major version bump (ERC 6.0 anyone?) > along with any other potential breaking change we might want to make. Agreed (let's break it all)! Seriously, though, I really appreciate your taking the time to review these. > Also your simplification sounds good. I pushed the v2 of all three > patches from your other reply to emacs-29. Sweet, thanks so much.