From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60144: 30.0.50; PGTK Emacs crashes after signal Date: Sun, 18 Dec 2022 20:12:53 +0800 Message-ID: <871qowgbay.fsf@yahoo.com> References: <87edsxfop0.fsf@yahoo.com> <83359dgt7v.fsf@gnu.org> <87a63lfcz7.fsf@yahoo.com> <83y1r5f6lh.fsf@gnu.org> <875ye9f385.fsf@yahoo.com> <83fsddey48.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24118"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60144@debbugs.gnu.org, karl@karlotness.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 13:47:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6t5A-0005zC-QO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 13:47:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6sYP-0008LZ-Df; Sun, 18 Dec 2022 07:14:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6sYM-0008LL-QZ for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 07:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6sYM-0005VF-DD for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 07:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6sYM-0008Oi-6W for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 07:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60144 X-GNU-PR-Package: emacs Original-Received: via spool by 60144-submit@debbugs.gnu.org id=B60144.167136559332264 (code B ref 60144); Sun, 18 Dec 2022 12:14:02 +0000 Original-Received: (at 60144) by debbugs.gnu.org; 18 Dec 2022 12:13:13 +0000 Original-Received: from localhost ([127.0.0.1]:33622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6sXZ-0008OK-Cl for submit@debbugs.gnu.org; Sun, 18 Dec 2022 07:13:13 -0500 Original-Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:41780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6sXY-0008O9-1A for 60144@debbugs.gnu.org; Sun, 18 Dec 2022 07:13:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1671365585; bh=BMv3eyDgSkRhr0YMokzmnJBlFCAxuEykD4o4pQSVWOc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=POfnJntXY1ADktdd+mROGor4MFh+reUvlKz3yuROMBswylXY9aDnZrYUDwCVKThaXHjykHW4PmnbmCPWlV0zRGw9cQZbu5iZinrKeQhv2eXF0BGfiMQCdi3b6tL167RGBz26X05jOH6SUi+Rcoi49nkqDKqcTgPiAKy3QGk3isnocP7VK8cHrbLQwQ+9gkTGpv25cXfed7csWNktPYMA768oyWud1zHrN+KFmLPFwcctRLvP0oO91kNAXrprNNL18Xh1PO9T6dQCWBPgh7M1hdIarAmUJusLAUOblc9Jzjyc+lqFEbwXER8lG8e3SZ7PFZ/auVbaQWNZz49J5lW9xA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1671365585; bh=E6vxcFkbyuW1Lq4j8lyupZhpINkYBxCyExfhA06FS2+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uKQaKuWjWYlZpdyyCvvQxtZJQfjSvPzLXeUwx65tggR+NTcGWpmY1pofzFbO46TjK8VlsC4FMzB/XrpixzVEfAIn2Fg5VnsBJ9Gi59pbSEY620ClDqHufG7r2Os0ImvAWtNgwKuoiGonCis6KqgUqkBVEKAza/1FJbLOYK8xBwDsdVUexY+q6lS13iw7FCuGsd/x92lnuFb4E/oREwlJ0R+5g0Fz5ddOf5NXGbDFnPxN7raDrhAR5lMNxIjgFI4IY4kdPHQHPv2iTPLGSezY0zSAQcCEwqf0RWHNxC4gb8UGuEI2+IKw5psekudLETJS0q40T/HlWMznIt7yCZX+uQ== X-YMail-OSG: L.SbkCcVM1mK4N4i6Sp4cQfkE6NHrJJGcKjfajk0htQcmCmzaYmeTvKhgJ_AXOq wsiGD6IvHDFRz1qsCYMurSTpd_8Daq9Gxv2LiyjO6jO_l0UE0dsJqd78iHLa4FbrYChNKku84hHA ZNz3Ka2_..F_GFXl3bivj6LaeMIkt3OVZwkAC1hZyYEe0jNWw4OTxmWoP9QmsBKutmYnuIvi8Ba1 YIuehY5vOFLEgEkbpzibcm7vKSGem7fiyaaCgdJ74IRkq82Afp5_mXrR_GU1YjCT10x46G._Irnv yQO1z3OISzlQDkTcJzXkuWfZxXf6rtXJU4BNCrIpnzRGli36_7m.5CNIUTft7Nbuljpa.50.7HRQ dO6N4J_Xx0Xg.nOGoe33EJlb9W4jq841IYzMYyyQkteLjxZVL9EReKYJfOO.ZeYOdGwsbaf8vXL_ 6hwx1Nb5DIl9.aTig6P4zgKXDQFetU.Kryy6TFMrYu9XWteAQKg.Raa4saZcJGTqH8aW6neZFsd. I0lsfIHAQo_KEHg19mYR.sc8wH7Zt0tm12TVUCxlEluQEWev1m7uEzM7CwhpU_v2PPBcAXYaZK4G 7yO3UjZanKI49mPqk2vKDUEK2W7jzJv0YIMzJEFLfihkXmkR4ZQrslkeQGybZUDE_TjgSE6tLWmr gcxrBHGfo78SyYSv.nFR6UVRm57mUb8.TEbo7CMO7pQGzqJWAQfJ6X6S3j1enWDftclLzgjeqgMP m9ejXzZxfSVQPtxm89apxiMf63uRDTCvuDR8dbVB8drFpd1RCQcIAOabXXiqiEvsHKnIPK5ZYEVJ G8IUGYOdubYQ8gOl1L4q3h6I7SRSVcFlmaAaEhI4.C X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sun, 18 Dec 2022 12:13:05 +0000 Original-Received: by hermes--production-sg3-b666c6484-8hzhs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a06e367cf038923cbcd7ec6e607c216a; Sun, 18 Dec 2022 12:12:59 +0000 (UTC) In-Reply-To: <83fsddey48.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Dec 2022 13:43:03 +0200") X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251365 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: karl@karlotness.com, 60144@debbugs.gnu.org >> Date: Sun, 18 Dec 2022 17:52:42 +0800 >> >> > Why this fragile architecture of reading input events? Calling >> > functions of our Lisp machine from context where those functions >> > cannot signal an error is very dangerous, and cannot work well in >> > Emacs. Why cannot we have the reads through GTK only deliver events >> > to us, which we enqueue to our own event queue, and then we could >> > process that queue in the safe context of the Lisp machine, as (AFAIK) >> > we do on other platforms? >> >> No, signalling there is equally unsafe on the other platforms, where >> note_mouse_highlight is called from the same place(s): read_socket_hook, >> event_handler_gdk, et cetera. Just look at the callers of >> x_note_mouse_movement in xterm.c, or [EmacsView mouseMoved:] in >> nsterm.m. > > Sorry, I'm afraid I don't see the danger on other platforms. Please > explain. AFAIK, read_socket_hook is called from keyboard.c code which > reads input, and that code has no problem signaling an error. What am > I missing? That code has problems signalling errors, unless it is okay for unblock_input to signal. On the regular X build with GTK, handle_one_xevent is called from event_handler_gdk, which is called by GDK when it detects an event. handle_one_xevent can also be called from x_dispatch_event inside a popup menu, and during drag-and-drop. On NS, [EmacsView mouseMoved:] is called by the system from Objective-C. Out of all of those places, the only place where it is safe to signal is inside the drag-and-drop event loop. Signalling out of the rest will either lead to catastrophic blowups (if it happens inside event_handler_gdk or [EmacsView mouseMoved:]), or to grabs never being released and resource leaks inside a menu.