From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks Date: Wed, 11 Jan 2023 21:16:20 +0000 Message-ID: <871qo0vkkb.fsf@tcd.ie> References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> <83wn5slt22.fsf@gnu.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: larsi@gnus.org, 49160@debbugs.gnu.org, dick.r.chiang@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 11 22:17:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFiTK-0005lG-JX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Jan 2023 22:17:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFiT5-0007pl-0i; Wed, 11 Jan 2023 16:17:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFiT1-0007pQ-C5 for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 16:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFiT0-0006DY-JF for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 16:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFiT0-00029Z-Eg for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 16:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jan 2023 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49160 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49160-submit@debbugs.gnu.org id=B49160.16734717898231 (code B ref 49160); Wed, 11 Jan 2023 21:17:02 +0000 Original-Received: (at 49160) by debbugs.gnu.org; 11 Jan 2023 21:16:29 +0000 Original-Received: from localhost ([127.0.0.1]:44095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFiST-00028g-BG for submit@debbugs.gnu.org; Wed, 11 Jan 2023 16:16:29 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:36418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFiSR-00028T-JU for 49160@debbugs.gnu.org; Wed, 11 Jan 2023 16:16:28 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id bs20so16313206wrb.3 for <49160@debbugs.gnu.org>; Wed, 11 Jan 2023 13:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/AN8dX9Z73N634upTE0/hcBqwQzS9cdRI+MBQawKDoQ=; b=U88dKmi+AGMDqW2woFp+DHF6QJhJce4pIbrLQaayy4AplWvVJK6y0XrO8UE+4vDOJD K5pJgl3KQW/mpFEJPyVMe8/ajmvVveTiW5tzBucEodg6TbwrmlDs/sy5Nhg3uK+2azAf 8k47LLpUJvltLS36K3OMCRn89vz4zAPf7bDXjAHFHJI97htivaWg4TopgDQTaqpeItsN g2LnibgtlVxICgnqA1pSaAvkkC+gR4GvsXTSNKbPwzmPvHnwmARIT9VfQwwTzh+HE26s CbvUDoKzA+oqEw/1T5kyEcOSUecX6gpMwOJ7MtgYtv2YSZm9irGNM9eP/ZrrLEZ9HclA Cx3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/AN8dX9Z73N634upTE0/hcBqwQzS9cdRI+MBQawKDoQ=; b=ecAPb2elIfXZxWESGzHQzcB9iQMga0KTTDTiYpEgKQHLa7p3gxagUfevUEjKiALNWH MN2tujWPBRTRUonURoJlN5o8ICHvfc7oKyjeP+IQKAwyZCJTW9mL7sqBFyO8rR+N2fOW tJVoDX49mBytPKe4h9xoHQNE7couv0MYZ1Q7PxLrZSMp/5WydlSVGUhZMlmeonBlgrIp AEqyVxa9ZgyiBPgC+Pm6JsMYa8aMAZKU0IKJDl3RL/BVJJFPEWpJUGKKe9QL8fjRzkrB JMZQ0k6L23eHU9PBBFdwABAgBQrkrVaKuwxgOJuzs5MEW+Ff4PYK9mlGCJXGt1UqLXKC LNzg== X-Gm-Message-State: AFqh2koZU/CwBW27hjGCjKUIRTEORRWAmAOe1RiVqHI5nJXqyiGpaguB zw9xK7OkAfbWTo2nsNJ5HfC5L5GACF5TIbza X-Google-Smtp-Source: AMrXdXv7Z6xhv/GSN0o1L4qm7DO+4ITtBwomJKqEc5td19lmpeY06OWp4j4Q+ToY6E0+3AFvU15STA== X-Received: by 2002:a05:6000:1c05:b0:261:d8be:3046 with SMTP id ba5-20020a0560001c0500b00261d8be3046mr50040866wrb.0.1673471782005; Wed, 11 Jan 2023 13:16:22 -0800 (PST) Original-Received: from localhost ([109.78.59.75]) by smtp.gmail.com with ESMTPSA id bj27-20020a0560001e1b00b0023659925b2asm15174024wrb.51.2023.01.11.13.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 13:16:21 -0800 (PST) In-Reply-To: <83wn5slt22.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Jan 2023 15:22:32 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253171 Archived-At: Eli Zaretskii [2023-01-11 15:22 -0500] wrote: >> From: "Basil L. Contovounesios" >> Cc: Eli Zaretskii , 49160@debbugs.gnu.org, dick >> >> Date: Wed, 11 Jan 2023 20:13:21 +0000 >>=20 >> Fmake_indirect_buffer continues to run buffer-list-update-hook >> regardless of the new argument. Any objections to changing that? > > buffer-list-update-hook is not a buffer-hook, strictly speaking. Right, but it's inhibited together with 'strict' buffer-hooks (and documented as such) everywhere except for make-indirect-buffer: see get-buffer-create, generate-new-buffer, struct buffer, "(elisp) Buffer List", "(elisp) Creating Buffers", "(elisp) Buffer Internals", and etc/NEWS.28. In fact, "(elisp) Indirect Buffers" even says about make-indirect-buffer: *Note Creating Buffers, for the meaning of INHIBIT-BUFFER-HOOKS. Where "(elisp) Creating Buffers" elaborates: Both functions accept an optional argument INHIBIT-BUFFER-HOOKS. If it is non-=E2=80=98nil=E2=80=99, the buffer they create does not run the = hooks =E2=80=98kill-buffer-hook=E2=80=99, =E2=80=98kill-buffer-query-functions= =E2=80=99 (*note Killing Buffers), and =E2=80=98buffer-list-update-hook=E2=80=99 (*note Buffer Lis= t). This avoids slowing down internal or temporary buffers that are never presented to users or passed on to other applications. So while inhibit-buffer-hooks may be a slightly loose name, I think make-indirect-buffer should nevertheless heed it for buffer-list-update-hook as well, for the same reason this is done everywhere else. > So I'm not sure we want this. What is the real-life use case behind > this request? The real-life use case is satisfying this bug report+patch from me, fixing what seems like a simple oversight, and the ensuing peace of mind that I will be grateful for, of course ;). Thanks, --=20 Basil