From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62190: 30.0.50; analyze-text-conversion in Android Date: Thu, 16 Mar 2023 08:38:38 +0800 Message-ID: <871qlp5y41.fsf@yahoo.com> References: <87a60e7sdn.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62190-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 16 01:39:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcbeM-0008X3-5A for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Mar 2023 01:39:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcbe4-0004WI-6v; Wed, 15 Mar 2023 20:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcbe2-0004Vt-AQ for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 20:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcbe2-0001h6-17 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 20:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcbe1-0007gH-QH for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 20:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2023 00:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62190 X-GNU-PR-Package: emacs Original-Received: via spool by 62190-done@debbugs.gnu.org id=D62190.167892713429512 (code D ref 62190); Thu, 16 Mar 2023 00:39:01 +0000 Original-Received: (at 62190-done) by debbugs.gnu.org; 16 Mar 2023 00:38:54 +0000 Original-Received: from localhost ([127.0.0.1]:40796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcbdt-0007fu-Nh for submit@debbugs.gnu.org; Wed, 15 Mar 2023 20:38:54 -0400 Original-Received: from sonic313-9.consmr.mail.ne1.yahoo.com ([66.163.185.32]:45145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcbds-0007fg-3M for 62190-done@debbugs.gnu.org; Wed, 15 Mar 2023 20:38:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678927126; bh=ZTj+n8QEeV3Ae5O5cVR+hlnXBDyXrkZWHYtGnAH7e5w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=JrkD9qVMDOz2JFHOYl0aTnFNc7JUvDgiIE+CCDqnOR2b5NPbbxD8YfsJRyXBhchl21XRprtvDY9Nb9wZODwgUpjbqzisnt9q51Crhr4WmK1Qzpmm8vcegx3K2ndlMnUA24Et0d6455XqNT24zyBos9pdPFTNcoORmBBsR3cgrsU6vEPr42fVnCJuvpfoufoVy7feLsVBbdiOSsqUuGigJ2azYXcZoPxauMwDbZIUOsZbA3Q6hj1uX9BCNlozHTVgtICQb5pfaIomloR2PdOiXYUds6XPwBYindMmrWql8KA9Vb68oB4UArduOTCAqwNjsksMoqEFoyEfk0wi0DNbvw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678927126; bh=tfMlhI6ZBS6iOr3f7hHlKv5U7mk/4O2aPlhJ7CH0tVo=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bfnL4KxMYuSndBUOMU6wdYpUmMNmBTmmJfSJCOxh2Vc9bjvPPFEbGjuaN7eaw+HXKZX6xZAIldFb4oOcfSGG8E7gMlDgmCwGYikHeoro3qXzRYvjhv0T9eVuSDcfZvNXallrdo4IqlqosbAGBTRmGJJcy++t3lCrDIFdXRcwGHin86PfwE+fL71K1xsBTTEqxvKWHaySYGjFDJnwQIK+yOYG+dyoC87wDekZxthndfwLt40UTL0kNSNnNuQyhMeOCkvJvU5d4wmrL5f6MuFfXSfIs/eZsVECOXyNm2Jr9Z+FWxAg2FZK85iCR0XLt7H3uwsHca2Zz6SeXCktPhWXFg== X-YMail-OSG: 3D9v5NIVM1kSAw_jDE1DNA1GP4ubdHkcRx_WWuc_RFko5RaJsDlyBbUcKHo5zwn coJ60CF2HGr.yojSSsDJlhUHfK7yQyzXzVDX77QxIdba8UKPSlElfjUAKN_NSLjn.LZDJMOLMGWG PZgbEoswtD5_8uUcoJBFPQMUF0Kq4p0aBTKqw8YWDPqxwx8gWGjWFJApQSqHPVf.AJhP539ev5b9 kaUuHNVdVO0dhRPDPEsV2xe49c_ZEoTugBSxG1zx0zklTNlM5hfUUd74L5lB3j7jZK45gDoTb3aL d1M.yu4mnx7llNj3lTamE_d7nha2kH7EBl6jaSeiOCC2lw6pR2R9k3APrjhOCPvS77MuASofgwAi qWiHoVj3c7DVxLLa2liZjLJdfoOWx_YRmH9kZuRjbTzEL9Jd0SLGwW_zliG3XLKVHIhSoC46fvtt SAebaNuj4oVFakM9U8L_o7rpD2zSTQPoKTZD5HYpLp1p4yE1sT6_xwKC18yXjcxh2N_4ADpYByNQ S6U9wj2oO1Swda1_p23pa0RaHvGM9ddQq0kF81Wt8HMetHfQCR4EfrDBoS8vTJO_bUle4oxM0uZ_ os2QcZCBEa5oN2dMPVWKC1TdID0XzMDvBCFCqfDs6DOm1Gr3BuaM5m8Yt2oE.LJhsuUS9m2MnJe6 1eMjOt5HNgBqf.L9X2As02DNYG57nTbsT3YUDE7jE8Jq5cctnyhJ4R3RpdemcLiLjoRTz3MmJAKa rEK0Ef7EGUYD65M845fkqpn.yRhd98TDidu19SEOkj4pbpBiYQvnjiIohGBBlk74U2JnZbfYfSuJ jlV1NHemUSc57IdaAo_Sb_rVNOaQO4yZJ7mkhNlJwo X-Sonic-MF: X-Sonic-ID: 7b59f67c-abf6-43b5-9f81-b7bb0b5a7183 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 16 Mar 2023 00:38:46 +0000 Original-Received: by hermes--production-sg3-67c57bccff-9pwhc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6687048afd1519a517039b102582cd57; Thu, 16 Mar 2023 00:38:43 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 15 Mar 2023 13:52:51 -0400") X-Mailer: WebService/1.1.21311 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257995 Archived-At: Stefan Monnier writes: >> Stefan, this was already fixed on the feature/android months ago, by >> disabling text conversion in the middle of `read-key-sequence'. > > Sorry, I didn't realize it was so old. > >> I suggest you use (more) up-to-date prebuilts at: >> >> https://sourceforge.net/projects/android-ports-for-gnu-emacs/upload/ > > Will take a look at it, thanks. > >>> Maybe `text-conversion` should not be generated when we're "in the >>> middle" of `read-key-sequence`? Or maybe `text-conversion` should be >>> turned into a sequence of "normal" events via `input-decode-map`? >>> Or maybe more of the event processing should be done in ELisp and less >>> in C (i.e. the raw events would be exposed to ELisp and they'd be >>> processed a bit more like we do with our input-methods)? >>> >>> I'm not very knowledgeable about this topic (under Android I use my >>> on-screen keyboards as if they were normal keyboards, very rarely even >>> making use of the predictive features). >> >> Moving it to Lisp is unfortunately not possible, as Android input >> methods require 150% obedience from Emacs that can only be accomplished >> by hard wiring the logic in C. > > So maybe our best hope is to use `input-decode-map`? > > Some aspects might seem tricky (e.g. the fact that it could affect > several buffers), but OTOH `input-decode-map` should simplify some of > the code by removing the ad-hoc handling of electric-pair and auto-fill. Unfortunately not, because the effect of an input method edit is already performed prior to a `text-conversion' event being sent. The edit may also have been made to multiple frames, simultaneously. I suggest looking at the code in textconv.c, the functions which are decorated with `JNIEXPORT' in androidterm.c, and java/org/gnu/emacs/EmacsInputConnection.java. Thanks.