From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Thu, 13 Apr 2023 17:49:00 +0000 Message-ID: <871qknllkj.fsf@posteo.net> References: <87a5zj2vfo.fsf@gmail.com> <87zg7djrgr.fsf@gmail.com> <83o7nt73za.fsf@gnu.org> <83mt3d73c2.fsf@gnu.org> <87r0sptinq.fsf@posteo.net> <83jzyh706c.fsf@gnu.org> <875ya1tdwf.fsf@posteo.net> <83edop6sdy.fsf@gnu.org> <831qkp6o0i.fsf@gnu.org> <83wn2h5825.fsf@gnu.org> <87wn2gkhzr.fsf@posteo.net> <83cz485oxi.fsf@gnu.org> <87leiwdyff.fsf@posteo.net> <834jpk5hih.fsf@gnu.org> <871qkom3fj.fsf@posteo.net> <83mt3b4yfc.fsf@gnu.org> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21133"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 62720@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 13 19:49:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pn14b-0005IU-Jh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Apr 2023 19:49:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pn14C-00039d-MU; Thu, 13 Apr 2023 13:49:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pn14A-00039B-Vl for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 13:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pn14A-0007go-O1 for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 13:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pn14A-0005l5-JE for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 13:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Apr 2023 17:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168140812222101 (code B ref 62720); Thu, 13 Apr 2023 17:49:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 13 Apr 2023 17:48:42 +0000 Original-Received: from localhost ([127.0.0.1]:44726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn13q-0005kP-FC for submit@debbugs.gnu.org; Thu, 13 Apr 2023 13:48:42 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:47089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn13m-0005k1-Ao for 62720@debbugs.gnu.org; Thu, 13 Apr 2023 13:48:40 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 600882402CC for <62720@debbugs.gnu.org>; Thu, 13 Apr 2023 19:48:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681408112; bh=usGnlNkil8VH20nSNMBGV0KjCHHi5xvAGU93O2tjAdw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=da5Q9Mr8NXxddKNLij5N4E3RwLDH+RgXQuC7ppYTXr/FlWZtBKzSm3PEUfC4LsJ6D kxqIgJk9jUuPZltWc/R56i+y60yo9LbDEEufRL3f7z2KTEpO9Cjs0sfe0PkmIy02wV 0nzUfhK548joqwmM/eDw+5qD1BPsQYYgSAHW+qXAv6SF+JaLnrAqvrB9o0rM6Cdpe4 /WhGnTHlE3Azs0GbGFURbAQzJRc2rwndRJn4dHNbH4mSGg4KYnii1SZuz+krEGXpGI FOxpRjow3D0hgpF3Hs8DpdnPL7s/JHxqnqrFeW34M7Y+q31DrY/YqLM5t2O9F0dnzt FkIcZePLvzvOQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Py6WM2FFlz9rxG; Thu, 13 Apr 2023 19:48:31 +0200 (CEST) In-Reply-To: <83jzyf4vzb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Apr 2023 18:56:08 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259873 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: joaotavora@gmail.com, monnier@iro.umontreal.ca, 62720@debbugs.gnu.= org, >> larsi@gnus.org >> Date: Thu, 13 Apr 2023 15:10:01 +0000 >>=20 >> Eli Zaretskii writes: >>=20 >> >> The issue here is that this breaks the non-interactive invocations li= ke >> >> (package-install 'eglot), unless they invoke the function while bindi= ng >> >> `current-prefix-arg', which I don't think is a common practice. >> > >> > Then let's add another optional argument, and let prefix arg set it. >> > Would that resolve this issue? >>=20 >> That could solve it, but a user option might be more elegant. We could >> set it to nil for now, and change it to non-nil for the next release. > > Adding an option is fine by me, as long as its default preserves > previous behavior. > > Just to be sure we are on the same page: you suggest _both_ prefix > argument and user option, where user option could be used to avoid the > need for prefix argument? I was thinking about both, but I supposed that a user option would be enough. >> >> >> Note that (package-install 'eglot) does download code, but I belie= ve >> >> >> that this is the correct approach and would align with what Jo=C3= =A3o >> >> >> wanted. >> >> > >> >> > I'm not sure I follow: which code does the above download? >> >>=20 >> >> I did not change any of the code that downloads anything, all this do= es >> >> is prompt the user for built-in packages when invoked interactively w= ith >> >> a prefix argument and if package-install is invoked with a built-in >> >> package, then it will switch to the ELPA version. This will not happ= en >> >> in interactive usage, since `completing-read' is called with >> >> REQUIRE-MATCH. >> > >> > So you are saying that non-interactive calls to package-install could >> > install Eglot from ELPA even without the changes, is that right? >>=20 >> No, my proposed diff changes what package decides to download (the >> planning phase), but doesn't touch anything after that. The current >> state is that (package-install 'eglot) just prints >>=20 >> =E2=80=98eglot=E2=80=99 is already installed > > And does nothing else? You seem to be saying it still downloads > something, but what is that? No, it just prints that message but doesn't download anything.