From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible Date: Wed, 03 May 2023 10:40:28 +0200 Message-ID: <871qjxlseb.fsf@gmail.com> References: <87cz3ill2x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28892"; mail-complaints-to="usenet@ciao.gmane.io" To: 63236@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 03 10:41:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pu833-0007OU-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 May 2023 10:41:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pu82q-0002SU-8Z; Wed, 03 May 2023 04:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pu82o-0002Rz-Py for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 04:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pu82o-0004x0-Fr for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 04:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pu82o-0000dB-CM for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 04:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 May 2023 08:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63236 X-GNU-PR-Package: emacs Original-Received: via spool by 63236-submit@debbugs.gnu.org id=B63236.16831032382386 (code B ref 63236); Wed, 03 May 2023 08:41:02 +0000 Original-Received: (at 63236) by debbugs.gnu.org; 3 May 2023 08:40:38 +0000 Original-Received: from localhost ([127.0.0.1]:45533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu82Q-0000cQ-9T for submit@debbugs.gnu.org; Wed, 03 May 2023 04:40:38 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:62894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu82O-0000cC-OH for 63236@debbugs.gnu.org; Wed, 03 May 2023 04:40:37 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3f315735514so13720205e9.1 for <63236@debbugs.gnu.org>; Wed, 03 May 2023 01:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683103230; x=1685695230; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0QV7oUHWEA/bda+oyfLg2OAH7w/003pTzGIm5Wh3dxc=; b=HYGtZZPyVkzJK1ay1CJS3/uG8TdPAcE+mUjAZUt5YvdhMp3q3UHXWxIsKebthOfolV fTk7Mh1bROdBnzwebkkDGDFt3tnra8IsvCRfuVrfVlo0dK1OqLLzGRXX3iIdNfIjHveM Df8hYoe9VNPGWUP0T+/lKkowKh4kwPouOQzhmWp8EGczRVJfFQWyTclz6jlsWKjv7BFY nouUxt1b2bX7O1/YTftuB1ZZrQXYVQenkMMFuj8a9k3NyDQYiom41lOq6EVFSvEzLLKg M6sVM71A9s+C81+IoklbWiGClE99y3ypti5rxF7nrfeV9/dBl0ccwrIyz1rlf7n29cPe 6oiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683103230; x=1685695230; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0QV7oUHWEA/bda+oyfLg2OAH7w/003pTzGIm5Wh3dxc=; b=DcxTNq1zZeSt7Pq9+U907TP1cX4Do9IomTLZN5FooM/oXEpXVBqr8POZ7c8GCSw7/4 EzekBUiJ6ysQK/oyPuLBhg+3odAqSLfrgXeuR5Nsv4h/JLKpOm3ae27Oe9qMH8wfA8Al KoGg5BXp4AX3RHJUxd27FGR7/+bbtnWdEwPDO1nRL2e1ft+lj37+KRex2ynUs+YXXaXq VL8mTxumqDsJlo/aqj9hgDN6KEpb/rtvfd005aQ3Fj/liyPzmolxW22Tb+S8tfBCZDOa BLkdj3OHyoVTtFmOm213aOeQ4XkNvvSwARgwt81qaBXZfsJpiEQERh0LJIrd7NDZjXcw TZ4w== X-Gm-Message-State: AC+VfDwwFh+b+dYPI8YPeG4+4eA0y1vnwgDXaXdREBsz0cOBqSkkH3bk E9c4tdcksHWmWkPKfa/kfrhbJw+6vjU= X-Google-Smtp-Source: ACHHUZ6kpUQTl/8ArE3ddXQlsZ+ub0rK7RhhC0VdulhZykam6QrKsBywhSZqSSgodJCkCuJUw1tf3A== X-Received: by 2002:a05:600c:5102:b0:3f1:7510:62e8 with SMTP id o2-20020a05600c510200b003f1751062e8mr910469wms.3.1683103230354; Wed, 03 May 2023 01:40:30 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id q3-20020a1cf303000000b003f3157988f8sm1167891wmq.26.2023.05.03.01.40.29 for <63236@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 01:40:29 -0700 (PDT) In-Reply-To: <87cz3ill2x.fsf@gmail.com> (Robert Pluim's message of "Tue, 02 May 2023 19:06:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260968 Archived-At: >>>>> On Tue, 02 May 2023 19:06:14 +0200, Robert Pluim s= aid: Robert> I attempted to upgrade my packages today using `list-packages',= which Robert> errored out when regenerating the autoloads for vlf-write.el: Robert> Debugger entered--Lisp error: (search-failed "\n\f\n;;;") Robert> search-forward("\n\f\n;;;") Robert> loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.22= 50" "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-li= st 'load-path (or (and load-file-name (f...") Robert> package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vl= f-20191126.2250") The minimal patch I can come up with is this, which seems safe enough but I=CA=BCd appreciate it if someone who knows the code could comment diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen= .el index a966b1e9f40..c25950a1afd 100644 --- a/lisp/emacs-lisp/loaddefs-gen.el +++ b/lisp/emacs-lisp/loaddefs-gen.el @@ -637,7 +637,7 @@ loaddefs-generate (search-backward "\f\n" nil t)) ;; Delete the old version of the section. (delete-region (match-beginning 0) - (and (search-forward "\n\f\n;;;") + (and (re-search-forward "\n\f\n;;;?") (match-beginning 0))) (forward-line -2))) (insert head) Robert --=20