From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#64205: Fix missing cell border when using orgtbl-to-table.el function Date: Thu, 22 Jun 2023 16:38:48 +0200 Message-ID: <871qi3fton.fsf@gmail.com> References: <87ttv0g7nk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23466"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64205@debbugs.gnu.org, Eli Zaretskii To: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 22 16:39:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCLSy-0005zt-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jun 2023 16:39:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCLSl-00078c-N4; Thu, 22 Jun 2023 10:39:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCLSj-000781-33 for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 10:39:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCLSf-0008Kr-Pg for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 10:39:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCLSf-00078G-Ln for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 10:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jun 2023 14:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64205 X-GNU-PR-Package: emacs Original-Received: via spool by 64205-submit@debbugs.gnu.org id=B64205.168744473827407 (code B ref 64205); Thu, 22 Jun 2023 14:39:01 +0000 Original-Received: (at 64205) by debbugs.gnu.org; 22 Jun 2023 14:38:58 +0000 Original-Received: from localhost ([127.0.0.1]:36478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCLSb-00077z-RL for submit@debbugs.gnu.org; Thu, 22 Jun 2023 10:38:58 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:52286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCLSa-00077m-5z for 64205@debbugs.gnu.org; Thu, 22 Jun 2023 10:38:56 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3f9bece8d1bso20851535e9.0 for <64205@debbugs.gnu.org>; Thu, 22 Jun 2023 07:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687444730; x=1690036730; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=eKdfENg4nqX1fcF7VllxHNW6JAn9zR1tJFccXMYdvdE=; b=kd5A7UJm+6xcEBWdGiZ5w39CDMNJtidDFNu9xZSviaZBR7Y9ZpD18fF0N9+L4NMkWW 2eiubH5P1iIbMP+uGb/UXo2+7t1PKUb+UryRilVlcefc+MLz42Fe6AhL7NFBsUmvHUJf FJVM1xglgdKgbmT37p+565ki3igbDf81FtVyxT5kGfgi38sq22sWHL/1dsk5Ln/1B8Hb S66UDIv2xNATdMj8vtwu3hRHawuqVpKI4k00+uYeMHDc3ny3dgGs822kdMqVXHlZ6THD Je8+oRBGTdu1rtZlXtr9WF5ZsxZZw/ylkKwpkB9E48BV1zVfSimJnB+SAzlY+8pjnjUv OM+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687444730; x=1690036730; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eKdfENg4nqX1fcF7VllxHNW6JAn9zR1tJFccXMYdvdE=; b=E1WhXiSMvT8PUJHy2LH+Gm2AwW8GIMXE4fGPFC2ZnNzl9y8qz6z/A4HsIdjxKKkH0A Izzj+urR8JpeB/YDG53xvZRxGx6g4ysRbGxxTn+/jGKrOMDd9zF6ghBA3Ce+kcq/T2Yp aECxiXikvphvyUVTXhhBradFY2A0bwRHLeIbvLoBuKIwQAF8fKIYQ4VNBzbDLBg5lKNq cZlRJl2rZfwjXLmoTqXJzcE+/kbbVuBqKRaUxyX6RSsHVa/nt+7nsEIIY16PndQPc1SX 5Y7I7MXt5NLJvqA8w5OtUnDLjlCWmGl1Eh73nlxmcAWXS9FVcypm43/+4eKD2xwf2sgg YJVg== X-Gm-Message-State: AC+VfDxwCyY9OMC/sMDaLBca5SpOTzlEYuXEFyxCsXmLwuDsYd1rgjF9 jb6Ty1NIyHlDQoJxCULlgXc= X-Google-Smtp-Source: ACHHUZ6YBKdbgHOHD9GDVdFYu15pqD8CbmlU1hRsQVyDGc2YX2B4/3hN2Rdyq0LHjhaG58h0/Lzvkw== X-Received: by 2002:a05:600c:3794:b0:3f9:b30f:455f with SMTP id o20-20020a05600c379400b003f9b30f455fmr8210829wmr.9.1687444730047; Thu, 22 Jun 2023 07:38:50 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id l16-20020a1c7910000000b003f9bdf60b34sm4614146wme.11.2023.06.22.07.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 07:38:49 -0700 (PDT) In-Reply-To: ("Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?="'s message of "Thu, 22 Jun 2023 16:33:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263881 Archived-At: >>>>> On Thu, 22 Jun 2023 16:33:02 +0200, Jakub Je=C4=8Dm=C3=ADnek said: Jakub> Tags: patch Jakub> I forgot to mention that I=C2=B4ve fixed what you asked for, tha= nk you for Jakub> pointing that out. Thanks for that. Eli, is this small enough to go into master without paperwork? Thanks Robert Jakub> See attached. Jakub> Jakub Jakub> From 61024954e75c4e71ed48c0566e02fb6e67b3e688 Mon Sep 17 00:00:0= 0 2001 Jakub> From: =3D?UTF-8?q?Jakub=3D20Je=3DC4=3D8Dm=3DC3=3DADnek?=3D Jakub> Date: Wed, 21 Jun 2023 15:50:31 +0200 Jakub> Subject: [PATCH] Fix orgtbl-to-table.el function to include last= cell border Jakub> * lisp/org/org-table.el (orgtbl-to-table.el): Perform character Jakub> replacement in the temp buffer and fix missing cell border. (Bug= #64205) Jakub> --- Jakub> lisp/org/org-table.el | 10 +++++++--- Jakub> 1 file changed, 7 insertions(+), 3 deletions(-) Jakub> diff --git a/lisp/org/org-table.el b/lisp/org/org-table.el Jakub> index 42f234790c5..9a72eb5f314 100644 Jakub> --- a/lisp/org/org-table.el Jakub> +++ b/lisp/org/org-table.el Jakub> @@ -6132,9 +6132,13 @@ supported." Jakub> (with-temp-buffer Jakub> (insert (orgtbl-to-orgtbl table params)) Jakub> (org-table-align) Jakub> - (replace-regexp-in-string Jakub> - "-|" "-+" Jakub> - (replace-regexp-in-string "|-" "+-" (buffer-substring 1 (b= uffer-size)))))) Jakub> + (goto-char (point-min)) Jakub> + (while (search-forward "-|" nil t) Jakub> + (replace-match "-+")) Jakub> + (goto-char (point-min)) Jakub> + (while (search-forward "|-" nil t) Jakub> + (replace-match "+-")) Jakub> + (buffer-string))) =20 Jakub> (defun orgtbl-to-unicode (table params) Jakub> "Convert the `orgtbl-mode' TABLE into a table with unicode ch= aracters. Jakub> --=20 Jakub> 2.39.1 Robert --=20