From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Fri, 28 Jul 2023 18:00:52 +0200 Message-ID: <871qgsc9fv.fsf@ledu-giraud.fr> References: <874jruy7xx.fsf@ledu-giraud.fr> <83ilg8jzti.fsf@gnu.org> <87k00oo03r.fsf@ledu-giraud.fr> <838rh4jlsq.fsf@gnu.org> <87bklzol8n.fsf@ledu-giraud.fr> <877cwmo8ij.fsf@ledu-giraud.fr> <87y1oz54bn.fsf@ledu-giraud.fr> <87wn4dra0h.fsf@ledu-giraud.fr> <87bklhtwhd.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> <83wmykjzji.fsf@gnu.org> <877cqkcrds.fsf@ledu-giraud.fr> <83bkfwjkh8.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17535"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 18:36:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPQS2-0004Kn-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 18:36:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPPu3-0003jo-WA; Fri, 28 Jul 2023 12:01:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPPtn-0003gI-6o for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 12:01:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPPtm-0001XP-Q9 for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 12:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPPtm-0007cG-3Y for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 12:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.169056005929259 (code B ref 61394); Fri, 28 Jul 2023 16:01:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 28 Jul 2023 16:00:59 +0000 Original-Received: from localhost ([127.0.0.1]:45902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPPtj-0007br-1I for submit@debbugs.gnu.org; Fri, 28 Jul 2023 12:00:59 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:32559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPPtg-0007bh-2Q for 61394@debbugs.gnu.org; Fri, 28 Jul 2023 12:00:57 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ZnCSMEMb xDk2v30DNIF6KhFEf3xxJ6/1qrf7dFp/N6M=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=8jxahj2lQKyUSNtAbf/gYGKnVBNK3g Qf4x/wgAH8ZgT3N4hBoh44hHSEOnI/LU68hqi5JlrWjcz2RfqOT5PODw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ZnCSMEMbxDk2v30D NIF6KhFEf3xxJ6/1qrf7dFp/N6M=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=DffLY1s+X/TX95Vxlsz6uekVQj8OXMXymcuq+S JTszIXSXjmUuKfWneaBmiioMEXG48v+karYys2HI/6LcC7E92mPoCpI//w8ORVcIwgJoPY mhczCi9gDHY7JNsJCXFuLmGmVZntLDWpHktO3quDzMGyQ3gppH5W67+QF7iGU8K2/x1++f k2YlNC8KZRJp09IQMUlxda3hrzYezeGcwiJZitWVE30zbDJWd/bzJxgzY0UXm0nP9qLEJt wxmWlfCd1KiOnaFt5m6SBbV6xP1nKR65XqBy6q/pTzyAhQSvr4x9MXW5ZfjXOXthk60qkR ztstMcYsvQeKr+apj2EY+ZqA== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 57c74ce0 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 28 Jul 2023 18:00:54 +0200 (CEST) In-Reply-To: <83bkfwjkh8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Jul 2023 15:20:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266288 Archived-At: Eli Zaretskii writes: [...] >> Yes I think it does. My patch for bug#61394 changes the previous >> behaviour of 'image-dired-thumbnail-storage'. Now >> 'image-dired-thumbnail-storage' defines where (ie. in which directory) >> the thumbnails are stored and I introduce 'image-dired-thumb-naming' >> which tells how thumbnail file ared named (ie. the file name part sans >> directory). >> >> 'image-dired-thumb-naming' is meaning less if >> 'image-dired-thumbnail-storage' is one of the "standard*" method because >> those methods already define storage locations, file names and even >> sizes. But for the "per-directory" method, I'm using >> 'image-dired-thumb-naming'. As we are talking about thumbnail I did not >> think it was a big deal but if it is I can prepare a patch, on top of >> the one in place, and then 'image-dired-thumb-naming' will be used only >> for the "image-dired" storage method. WDYT? > > I don't think I understand all the aspects of this, as I use neither > image-dired nor the thumbnails. But it sounds like an incompatible > change in behavior wrt what we have in Emacs 29? If so, how do we > expect this to work for users who will have configured their Emacs for > some particular storage type, and then upgrade to Emacs 30 when that > is released? Will the existing thumbnails still work for them? Will > Emacs 30 now start storing thumbnails under differently-formatted > names, even though the user didn't change his/her configuration? AFAIU image-dired thumbnails' generation, this will automatically work for users from Emacs 29... but you are right that new thumbnails (with new names) will be generated. This will be true for users of the "per-directory" storage method. This will also be true when one user customize the 'image-dired-thumb-naming' to 'sha1-contents'. > In general, any incompatible change in behavior (if there is indeed > such a change caused by this changeset) is undesirable. So I'd like > first to discuss why there was a need for the behavior change in the > first place. If you talk about the behaviour change for the "per-directory" method, as I said, I can restore it back to what it was. -- Manuel Giraud